Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nix-prefetch-git: create parent directories #14909

Closed
wants to merge 1 commit into from

Conversation

zgraggen
Copy link
Contributor

Creating nested folders doesn't work with the current mkdir command. Adding the -p option to create parent directories.

@mention-bot
Copy link

By analyzing the blame information on this pull request, we identified @bjornfor, @nbp and @timbertson to be potential reviewers

@FRidh FRidh added the 0.kind: enhancement Add something new label Apr 23, 2016
@nbp nbp added this to the 16.09 milestone Apr 23, 2016
@nbp nbp added the 1.severity: mass-rebuild This PR causes a large number of packages to rebuild label Apr 23, 2016
@nbp
Copy link
Member

nbp commented Apr 23, 2016

@zgraggen , This modification will cause all the packages which are being fetched from git to be rebuild, thus we cannot accept this patch in master, as this would cause a lot of hashes to change, and this is not good for users who are following the unstable channel.

For mass-rebuild, we have the staging branch, which is where we merge all mass-rebuild changes, and this branch would later be merged in the master branch.

Otherwise the patch sounds good.

@zgraggen
Copy link
Contributor Author

Thanks for the feedback. So I should create a new pull request against staging?

@abbradar abbradar mentioned this pull request Apr 25, 2016
7 tasks
@abbradar
Copy link
Member

Closed by 5e85760. Thanks!

@abbradar abbradar closed this Apr 25, 2016
@zgraggen
Copy link
Contributor Author

Thanks for submitting it for me!

@Janik-Haag Janik-Haag added the 12. first-time contribution This PR is the author's first one; please be gentle! label Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.kind: enhancement Add something new 1.severity: mass-rebuild This PR causes a large number of packages to rebuild 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants