Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wine && mumble -- Fixes for post multiple-output issues #14776

Merged
merged 2 commits into from
Apr 17, 2016

Conversation

avnik
Copy link
Contributor

@avnik avnik commented Apr 17, 2016

Things done
  • Tested using sandboxing (nix-build --option build-use-chroot true or nix.useChroot on NixOS)
  • Built on platform(s)
    • NixOS
    • OS X
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

By analyzing the blame information on this pull request, we identified @abbradar, @wkennington and @bendlas to be potential reviewers

@abbradar
Copy link
Member

abbradar commented Apr 17, 2016

I have more "fundamental" fixes in #14770 and #14694 but I guess it'll take some time for them to get discussed (and maybe merged)...

@abbradar abbradar merged commit ce47fb3 into NixOS:master Apr 17, 2016
@avnik
Copy link
Contributor Author

avnik commented Apr 17, 2016

@abbradar wine really need to patch WINE_CHECK_SONAME macro in aclocal.m4, to detect full absolute paths. This make trick with RPATH unneeded at all

@dezgeg dezgeg added 0.kind: bug Something is broken 6.topic: closure size The final size of a derivation, including its dependencies labels Apr 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.kind: bug Something is broken 6.topic: closure size The final size of a derivation, including its dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants