bwbasic: init at 3.20 #146963
Merged
bwbasic: init at 3.20 #146963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I believe I've resolved all outstanding comments, please take another look. |
legendofmiracles
approved these changes
Nov 23, 2021
ofborg
bot
added
8.has: package (new)
veprbl
reviewed
Nov 23, 2021
|
|
||
| src = fetchzip { | ||
| url = "mirror://sourceforge/project/bwbasic/bwbasic/version%203.20/bwbasic-3.20.zip"; | ||
| extension = "zip"; |
There was a problem hiding this comment.
The ".zip" extension is now detectable from url.
Also, you don't need to use fetchzip, you can use fetchurl and put unzip in nativeBuildInputs. The benefit of using fetchurl over fetchzip is that the https://github.com/NixOS/nixpkgs/blob/master/maintainers/scripts/copy-tarballs.pl supports backing up those files to tarballs.nixos.org.
There was a problem hiding this comment.
Ah thanks! Good to know. I am in favor of backups, for sure, so I've changed that.
Do you know if it's possible to make this work without writing my own unpackPhase (as the latest revision does)?
veprbl
approved these changes
Nov 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes