keen4: convert away from builder.sh #146713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
ofborg
bot
added
10.rebuild-darwin: 0
l0b0
reviewed
Nov 20, 2021
| url = "http://tarballs.nixos.org/keen4.zip"; | ||
| sha256 = "12rnc9ksl7v6l8wsxvr26ylkafzq80dbsa7yafzw9pqc8pafkhx1"; | ||
| }; | ||
|
|
||
| nativeBuildInputs = [ unzip ]; | ||
|
|
||
| inherit dosbox; | ||
| installPhase = '' | ||
| mkdir -p $out/share/keen4 |
There was a problem hiding this comment.
Variable substitutions should be quoted to allow for whitespace in filenames. Ditto in the rest of the script.
There was a problem hiding this comment.
$out cannot contain any whitespace or everything will fall apart. There are probably many more changes required to make this work with whitespaces and should probably be an RFC.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
diffed with diffoscope and output identical
Motivation for this change
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes