vscode: switch to unfree, binary package #14447
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
As described in #14354, the current
vscode
derivation fails to build on hydra, due to the expression depending onnpm install
.There are a lot
nodePackage
dependencies that are missing in thenixpkgs
collection (some of them must be natively build). I guess that would take quite some effort to getvscode
to successfully build from source.Hence, this PR switches the drv to use the unfree, pre-built binary and patchElf it accordingly. That could be changed in future of course.
Questions:
I don't have a Mac to test this, how does the binary find the shared libraries on a darwin architecture? AFAIU, patchELF only works on linux platforms. Should I remove
darwin
as a build target for this derivation?Things done:
nix-build . --option build-use-chroot true -A vscode
)nix-shell -I nixpkgs=. --pure -p vscode
)nix-shell -p nox --run "nox-review wip"
from root of nixpkgs forkvscode
compiles & runs./result/bin/
)More
Fixes issue #14354