Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vscode: switch to unfree, binary package #14447

Merged
merged 2 commits into from
Apr 14, 2016
Merged

Conversation

mucaho
Copy link
Contributor

@mucaho mucaho commented Apr 4, 2016

Motivation:

As described in #14354, the current vscode derivation fails to build on hydra, due to the expression depending on npm install.
There are a lot nodePackage dependencies that are missing in the nixpkgs collection (some of them must be natively build). I guess that would take quite some effort to get vscode to successfully build from source.
Hence, this PR switches the drv to use the unfree, pre-built binary and patchElf it accordingly. That could be changed in future of course.

Questions:

I don't have a Mac to test this, how does the binary find the shared libraries on a darwin architecture? AFAIU, patchELF only works on linux platforms. Should I remove darwin as a build target for this derivation?

Things done:
  • Tested using buildtime sandboxing (nix-build . --option build-use-chroot true -A vscode)
  • Tested using runtime sandboxing (nix-shell -I nixpkgs=. --pure -p vscode)
  • Built on platform(s)
    • NixOS
    • OS X
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip" from root of nixpkgs fork
    • dependent pkg vscode compiles & runs
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.
More

Fixes issue #14354

mkucko added 2 commits April 4, 2016 17:34
@mention-bot
Copy link

By analyzing the blame information on this pull request, we identified @fluffynukeit, @vcunat and @gebner to be potential reviewers

@jgillich
Copy link
Member

👍 Works for me, while the current package doesn't even build (due to chroot I suppose).

@vcunat

@joachifm joachifm merged commit 19e425f into NixOS:master Apr 14, 2016
@mucaho mucaho deleted the vscode_unfree branch April 28, 2016 21:22
@gebner gebner mentioned this pull request Nov 9, 2017
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants