Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

swaycwd: 0.0.1 -> 0.0.2 #142093

Merged
merged 1 commit into from
Oct 18, 2021
Merged

swaycwd: 0.0.1 -> 0.0.2 #142093

merged 1 commit into from
Oct 18, 2021

Conversation

cab404
Copy link
Member

@cab404 cab404 commented Oct 18, 2021

Motivation for this change

Updated (and fixed) swaycwd

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@figsoda
Copy link
Member

figsoda commented Oct 18, 2021

I would prefer using rec instead of having a separate variable

@cab404 cab404 force-pushed the swaycwd-0.0.2 branch 3 times, most recently from 0d8d85b to 840be14 Compare October 18, 2021 15:06
@cab404
Copy link
Member Author

cab404 commented Oct 18, 2021

I would prefer using rec instead of having a separate variable

well, alright. I kinda try to not use it excessively cause it clutters scope, but it's a small derivation

@cab404
Copy link
Member Author

cab404 commented Oct 18, 2021

also ran nixpkgs-fmt

pkgs/tools/wayland/swaycwd/default.nix Outdated Show resolved Hide resolved
@ofborg ofborg bot requested a review from ehmry October 18, 2021 15:35
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Oct 18, 2021
@figsoda
Copy link
Member

figsoda commented Oct 18, 2021

Result of nixpkgs-review pr 142093 run on x86_64-linux 1

1 package built:
  • swaycwd

@figsoda figsoda merged commit b04f913 into NixOS:master Oct 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants