zfs: strip debug symbols (closure size) #141942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
initrd-linux: -12427.8 KiB linux: -12419.3 KiB nc2k9ym14spzz2pgq6hn84k8k9zgf686: ∅ → ε, +102451.2 KiB nixos-system-turingmachine: 21.11.20211015.a2dcfa2 → 21.11.20211017.c6f77b7 visjwxsjqmh8c9lxnrxsw5w19zszflm6: ε → ∅, -102451.0 KiB zfs-kernel: -12419.3 KiB
ofborg
bot
added
11.by: package-maintainer
This was referenced Oct 17, 2021
|
How come the normal strip hook wasn't catching this? |
|
Oh, I guess because it gets compressed? |
alyssais
approved these changes
Oct 17, 2021
Atemu
reviewed
Oct 17, 2021
Comment on lines
+143
to
+146
| postBuild = optionalString buildKernel '' | ||
| find . -name "*.ko" -print0 | xargs -0 -P$NIX_BUILD_CORES strip --strip-debug | ||
| ''; | ||
|
|
There was a problem hiding this comment.
I'd prefer a comment here explaining why this is necessary
hmenke
reviewed
Oct 17, 2021
| @@ -140,6 +140,10 @@ let | |||
| "INSTALL_MOD_PATH=\${out}" | |||
| ]; | |||
|
|
|||
| postBuild = optionalString buildKernel '' | |||
| find . -name "*.ko" -print0 | xargs -0 -P$NIX_BUILD_CORES strip --strip-debug | |||
There was a problem hiding this comment.
Is it guaranteed that NIX_BUILD_CORES will always be non-empty? Otherwise this might be better:
Suggested change
| find . -name "*.ko" -print0 | xargs -0 -P$NIX_BUILD_CORES strip --strip-debug | |
| find . -name "*.ko" -print0 | xargs -0 -P''${NIX_BUILD_CORES:-1} strip --strip-debug |
|
AFAICS this PR has broken |
|
strip should be present, if it's not, then that's more of an issue with pkgsCross. |
|
This hardcodes strip but you should not use |
13 tasks
|
@martinetd thanks, using I've submitted #143539 for merging that fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we enabled BTF the zfs module size became significantly larger due to included debug symbols.
Closure size changes on my system when upgrading:
initrd-linux: -12427.8 KiB
linux: -12419.3 KiB
nc2k9ym14spzz2pgq6hn84k8k9zgf686: ∅ → ε, +102451.2 KiB
nixos-system-turingmachine: 21.11.20211015.a2dcfa2 → 21.11.20211017.c6f77b7
visjwxsjqmh8c9lxnrxsw5w19zszflm6: ε → ∅, -102451.0 KiB
zfs-kernel: -12419.3 KiB
Fixes #140851
Motivation for this change
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)