Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

podman: remove darwin wrapper #141061

Merged
merged 1 commit into from
Oct 11, 2021
Merged

podman: remove darwin wrapper #141061

merged 1 commit into from
Oct 11, 2021

Conversation

zowoq
Copy link
Contributor

@zowoq zowoq commented Oct 9, 2021

Motivation for this change
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@zowoq
podman: remove darwin wrapper
d532260 
- wrapping gvproxy doesn't work since 3.4
- store paths are written to config files which then break when GCed
@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Oct 9, 2021
@zowoq zowoq mentioned this pull request Oct 9, 2021
Closed
@zowoq zowoq linked an issue Oct 9, 2021 that may be closed by this pull request
podman machine VM fails to start on MacOS due to gvproxy runtime path resolution #141041
Closed
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Oct 9, 2021
saschagrunert
saschagrunert approved these changes Oct 11, 2021
View reviewed changes
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zowoq zowoq merged commit 1b4cdac into NixOS:master Oct 11, 2021
@zowoq zowoq deleted the podman-darwin branch October 11, 2021 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saschagrunert saschagrunert saschagrunert approved these changes

@adisbladis adisbladis Awaiting requested review from adisbladis

@kalbasit kalbasit Awaiting requested review from kalbasit

@marsam marsam Awaiting requested review from marsam

@vdemeester vdemeester Awaiting requested review from vdemeester

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

podman machine VM fails to start on MacOS due to gvproxy runtime path resolution
2 participants
@zowoq @saschagrunert