Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vimPlugins followup #137885

Merged
merged 5 commits into from
Sep 17, 2021
Merged

vimPlugins followup #137885

merged 5 commits into from
Sep 17, 2021

Conversation

teto
Copy link
Member

@teto teto commented Sep 14, 2021

Motivation for this change

trying to address some vim issues possibly triggered by #136429

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@r-rmcgibbo
Copy link

r-rmcgibbo commented Sep 14, 2021

Result of nixpkgs-review pr 137885 at b95ce9ce run on x86_64-linux 1

8 packages built successfully:
  • spacevim
  • tests.vim.test_vim_with_custom_plugin
  • tests.vim.test_vim_with_vim_nix
  • tests.vim.test_vim_with_vim_nix_using_pathogen
  • tests.vim.test_vim_with_vim_nix_using_plug
  • tests.vim.test_vim_with_vim_nix_using_vam
  • tests.vim.vim_with_vim2nix
  • vimacs

Result of nixpkgs-review pr 137885 at b95ce9ce run on aarch64-linux 1

1 package built successfully:
  • spacevim

@figsoda
Copy link
Member

figsoda commented Sep 15, 2021

@ofborg build neovim neovim.tests

@teto teto marked this pull request as draft September 16, 2021 09:58
@teto teto force-pushed the fix-vim-plug branch 2 times, most recently from 2bb35c5 to c4bd116 Compare September 16, 2021 20:34
@teto teto marked this pull request as ready for review September 16, 2021 20:40
@teto
Copy link
Member Author

teto commented Sep 16, 2021

@minijackson could you check it fixes the tag generation for you ?

to check that it can correctly load the colorscheme
Matthieu Coudron added 3 commits September 17, 2021 16:00
@teto
Copy link
Member Author

teto commented Sep 17, 2021

this does not fix the vim-plug issue (will try again once I can reproduce the issue), but it adds some more testing, especially for tag generation.

@teto teto merged commit 4ad9704 into NixOS:master Sep 17, 2021
@teto teto deleted the fix-vim-plug branch September 17, 2021 14:50
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/nvim-helptags-not-generated/15083/2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants