Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

windowManager.xmonad: Make it configurable and extensible. #1366

Closed
wants to merge 1 commit into from

Conversation

the-kenny
Copy link
Contributor

The previous windowManager.xmonad option only starts xmonad and
doesn't make ghc available. This assumes that the user has GHC with
access to the xmonad package in his PATH when using xmonad.

My (or specific: @aristidb and my) changes make it possible to use
Xmonad without adding GHC to any profile. This is useful if you want
to add a different GHC to your profile.

This commit introduces some options:

  • xmonad.haskellPackages: Controls which Haskell package set & GHC set
    is used to (re)build Xmonad
  • xmonad.extraPackages: Function returning a list of additional
    packages to make available to GHC when rebuilding Xmonad
  • xmonad.enableContribExtras: Boolean option to build xmonadContrib
    and xmonadExtras.

@aristidb
Copy link
Contributor

It should be noted that the commit also changes xmonad to accept a XMONAD_GHC option telling it which ghc to use.

@bjornfor
Copy link
Contributor

Looks good to me.

Maybe add a "type = types.bool" for "enableContribAndExtras" option?

@the-kenny
Copy link
Contributor Author

Whoops - sorry. Forgot that.

I'll push another small addition later today, please don't merge until then.

On Wed, Dec 25, 2013 at 8:24 PM, Bjørn Forsman [email protected]:

Looks good to me.

Maybe add a "type = types.bool" for "enableContribAndExtras" option?


Reply to this email directly or view it on GitHubhttps://github.com//pull/1366#issuecomment-31204080
.

@the-kenny
Copy link
Contributor Author

Force-pushed a rebased version to make merging easier. Should be ready to merge now.

@the-kenny
Copy link
Contributor Author

Wait, another small addition suggested by @aristidb is incoming...

The previous windowManager.xmonad option only starts xmonad and
doesn't make ghc available. This assumes that the user has GHC with
access to the xmonad package in his PATH when using xmonad.

Xmonad in Nix is now patched to accept the XMONAD_{GHC,XMESSAGE}
environment variables which define the path to either ghc or xmessage.
These are set automatically when using xmonad through
windowManager.xmonad.

My (or specific: @aristidb and my) changes make it possible to use
Xmonad without adding GHC to any profile. This is useful if you want
to add a different GHC to your profile.

This commit introduces some options:

- xmonad.haskellPackages: Controls which Haskell package set & GHC set
  is used to (re)build Xmonad

- xmonad.extraPackages: Function returning a list of additional
  packages to make available to GHC when rebuilding Xmonad

- xmonad.enableContribExtras: Boolean option to build xmonadContrib
  and xmonadExtras.

Signed-off-by: Moritz Ulrich <[email protected]>
@ocharles
Copy link
Contributor

Is that the patch that adds a full path to xmessage?
On 25 Dec 2013 20:29, "Moritz Ulrich" [email protected] wrote:

Wait, another small addition suggested by @aristidbhttps://github.com/aristidbis incoming...


Reply to this email directly or view it on GitHubhttps://github.com//pull/1366#issuecomment-31204848
.

@the-kenny
Copy link
Contributor Author

Yes, xmonad will now use XMONAD_XMESSAGE if set.

the-kenny added a commit that referenced this pull request Dec 28, 2013
PR #1366
The previous windowManager.xmonad option only starts xmonad and
doesn't make ghc available. This assumes that the user has GHC with
access to the xmonad package in his PATH when using xmonad.

Xmonad in Nix is now patched to accept the XMONAD_{GHC,XMESSAGE}
environment variables which define the path to either ghc or xmessage.
These are set automatically when using xmonad through
windowManager.xmonad.

My (or specific: @aristidb and my) changes make it possible to use
Xmonad without adding GHC to any profile. This is useful if you want
to add a different GHC to your profile.

This commit introduces some options:

- xmonad.haskellPackages: Controls which Haskell package set & GHC set
  is used to (re)build Xmonad

- xmonad.extraPackages: Function returning a list of additional
  packages to make available to GHC when rebuilding Xmonad

- xmonad.enableContribExtras: Boolean option to build xmonadContrib
  and xmonadExtras.

Signed-off-by: Moritz Ulrich <[email protected]>
@vcunat
Copy link
Member

vcunat commented Dec 28, 2013

Looks very good, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants