Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

podman: 3.2.3 -> 3.3.0 #134998

Merged
merged 3 commits into from
Aug 23, 2021
Merged

podman: 3.2.3 -> 3.3.0 #134998

merged 3 commits into from
Aug 23, 2021

Conversation

zowoq
Copy link
Contributor

@zowoq zowoq commented Aug 20, 2021

Motivation for this change
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@zowoq zowoq marked this pull request as draft August 20, 2021 20:51
@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Aug 20, 2021
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Aug 20, 2021
@saschagrunert
Copy link
Member

LGTM

@zowoq zowoq marked this pull request as ready for review August 23, 2021 20:59
@zowoq zowoq merged commit d7f344b into NixOS:master Aug 23, 2021
@zowoq zowoq deleted the podman branch August 23, 2021 20:59
@StephenWithPH
Copy link
Contributor

Adding pointer to #141041... it seems recent podman changes regarding runtime resolution of the path to gvproxy broke this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@saschagrunert saschagrunert saschagrunert approved these changes

@vdemeester vdemeester Awaiting requested review from vdemeester

@kalbasit kalbasit Awaiting requested review from kalbasit

@adisbladis adisbladis Awaiting requested review from adisbladis

@marsam marsam Awaiting requested review from marsam

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zowoq @saschagrunert @StephenWithPH @SuperSandro2000