Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/gdm: remove udev-settle dependency #134302

Merged
merged 1 commit into from
Sep 15, 2021

Conversation

rnhmjoj
Copy link
Contributor

@rnhmjoj rnhmjoj commented Aug 16, 2021

Motivation for this change

See #73095

It looks like it can finally be removed: the Failed to open gpu '/dev/dri/card0' error is gone and the nixosTests.gnome test is passing (checked 4 times in a row).

Things done

See NixOS#73095

It looks like it can finally be removed: the `Failed to open gpu
'/dev/dri/card0'` error is gone and the nixosTests.gnome test is
passing (checked 4 times in a row).
@rnhmjoj rnhmjoj requested a review from jtojnar August 16, 2021 09:44
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Aug 16, 2021
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Aug 16, 2021
@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Aug 16, 2021

@GrahamcOfBorg test gnome

@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Sep 8, 2021

ping @NixOS/gnome @dasj19 @maxeaubrey

@rvl
Copy link
Contributor

rvl commented Sep 15, 2021

I just tested this PR cherry-picked onto nixos-unstable (364b555).

The problem I was having where my laptop took 3 minutes to boot is now fixed, and gnome3 (with GDM and xorg) works fine. Thanks!

@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Sep 15, 2021

Thank you for helping out! I'm merging this now.

@rnhmjoj rnhmjoj merged commit 0e848f7 into NixOS:master Sep 15, 2021
@rnhmjoj rnhmjoj deleted the gdm-no-udev-settle branch July 10, 2023 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants