Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding pygame.patch #134

Closed
wants to merge 1 commit into from
Closed

Conversation

MarcWeber
Copy link
Contributor

No description provided.

@MarcWeber
Copy link
Contributor Author

This fixes breakage of #133

@7c6f434c
Copy link
Member

7c6f434c commented Oct 5, 2012

Does the current state of pygame expression work?

@MarcWeber
Copy link
Contributor Author

Yes - it works. It got removed by Peter within 2 hours or such. Probably I should resubmit it along with plover after having done some more testing on plover (still waiting for a new keyboard ..)

@viric
Copy link
Member

viric commented Dec 27, 2012

What is this pull-request about?

@viric
Copy link
Member

viric commented Dec 27, 2012

For what I understood, Marc proposed a change in #133, which was incorrect (10b3a56). Then Marc fixed it in this pull request, but Peter reverted the merge of #133 in 310c7be and then this pull request doesn't apply trivially anymore.

@peti
Copy link
Member

peti commented Feb 21, 2013

The expression doesn't build after this patch has been applied. The problem is that it adds a section

patchPhase = ''
  sed -i 's@raw_input(.*@"1"@' config_unix.py
  unset patchPhase
  patchPhase
'';

to the gcovr expression, but that package doesn't contain a file called config_unix.py, so sed exits with a non-zero error code. Also, the path to the actual patch file still isn't correct. @MarcWeber, I think it would be best if you'd re-test this patch and submit a new pull request once you're sure that the change works fine.

@peti peti closed this Feb 21, 2013
the-kenny added a commit to the-kenny/nixpkgs that referenced this pull request Jul 24, 2013
This set of Emacs packages corresponds to evaluation NixOS#134 of next on
http://hydra.tarn-vedra.de. It contains 914 successfully build
packages and 102 failures (mostly invalid package declarations).

Signed-off-by: Moritz Ulrich <[email protected]>
@primeos primeos mentioned this pull request Aug 19, 2018
12 tasks
ethancedwards8 pushed a commit to ethancedwards8/nixpkgs that referenced this pull request Apr 2, 2021
Apparently this doesn't exist by default, so make sure it's created
first.

Fixes NixOS#134
modulitos pushed a commit to modulitos/nixpkgs that referenced this pull request Nov 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants