Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lisp-packages.nix: update Nyxt #131665

Closed
wants to merge 2 commits into from
Closed

lisp-packages.nix: update Nyxt #131665

wants to merge 2 commits into from

Conversation

jmercouris
Copy link

@jmercouris jmercouris commented Jul 27, 2021

@7c6f434c

These are the changes I had to make to update Nyxt for NixOS.

Closes #127906

@7c6f434c
Copy link
Member

Hmmm, so you need CL-WebKit2 fresher than the latest Quicklisp? Or would it be enough to run Quicklisp update?

(also, I think you said you expected an extra package to be needed)

@jmercouris
Copy link
Author

We sometimes need cl-webkit2 fresher than the latest quicklisp. We need extra packages for 2.2.0, and 2.3.0.

@7c6f434c
Copy link
Member

I am not exactly eager to edit generated files, and putting the real version into overrides sounds «update-forgetting-prone»… So I guess globally the way to go is to add cl-webkit2-nyxt in lispPackages that overrides the Quicklisp-converted version.

@jmercouris
Copy link
Author

Perhaps that is the solution, in any case, I don't know how to make it happen. When 2.3.0 comes out I will ping you with the new dependencies and then we could do it at that time. I think that makes the most sense. What do you think?

@r-rmcgibbo
Copy link

r-rmcgibbo commented Jul 28, 2021

Result of nixpkgs-review pr 131665 at c74db90 run on x86_64-linux 1

3 packages built successfully:
  • lispPackages.cl-webkit2
  • lispPackages.nyxt
  • nyxt

Result of nixpkgs-review pr 131665 at c74db90 run on aarch64-linux 1

1 package built successfully:
  • nyxt

@pjones
Copy link
Contributor

pjones commented Oct 15, 2021

Is there a way to locally override lispPackages with something like an overlay? I want to use a newer nyxt but since lispPackages is just an attribute set I'm not sure how to override nyxt and cl-webkit2.

@7c6f434c
Copy link
Member

Well, you can use // { cl-webkit-2 = …; nyxt = …; }, as ot's not a deep override

@pjones
Copy link
Contributor

pjones commented Oct 16, 2021

@7c6f434c Oh, that's interesting. I didn't think the cl-webkit-2 change would propagate into the nyxt attribute. I'll give it a shot.

@7c6f434c
Copy link
Member

7c6f434c commented Oct 16, 2021

@pjones you can always override, or even clone the expression and pass it whatever version you want. (Sure, it won't propagate per se, unless you do some magic)

@jmercouris
Copy link
Author

@7c6f434c can you please remind me how I would test my local nixpkgs checkout/modifications?

I have cloned NixOS/nixpkgs, and made some changes, I then try to do:

sudo nix-env -i nyxt -I nixpkgs=/the/path/to/my/checkout

but for some reason it always ends up installing 'nyxt-2020-10-23'...

@jmercouris
Copy link
Author

Nevermind, I found the answer here: https://nixos.wiki/wiki/Nixpkgs/Create_and_debug_packages

it seems my documentation was outdated.

@SuperSandro2000 SuperSandro2000 added the 2.status: merge conflict This PR has merge conflicts with the target branch label Nov 22, 2021
@7c6f434c 7c6f434c closed this Dec 30, 2021
@7c6f434c
Copy link
Member

A proper Quicklisp update has happened since, and together with Nyxt update to a fresher version

@Janik-Haag Janik-Haag added the 12. first-time contribution This PR is the author's first one; please be gentle! label Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.status: merge conflict This PR has merge conflicts with the target branch 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants