Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

buildPythonApplication: use new function for Python applications #13124

Merged
merged 1 commit into from
Feb 23, 2016

Conversation

FRidh
Copy link
Member

@FRidh FRidh commented Feb 19, 2016

In 49c6893 buildPythonApplication was introduced.
This commit converts (almost) all occurrences of buildPythonPackage with buildPythonApplication except those in

  • pkgs/top-level/python-packages.nix
  • pkgs/development/python-modules/

@mention-bot
Copy link

By analyzing the blame information on this pull request, we identified @aszlig, @roblabla and @bosu to be potential reviewers

@FRidh
Copy link
Member Author

FRidh commented Feb 19, 2016

cc @domenkozar

@FRidh FRidh force-pushed the buildPythonApplication branch from e598e78 to 4d06bf7 Compare February 19, 2016 12:17
@FRidh FRidh changed the title buildPythonPackage -> buildPythonApplication buildPythonApplication: use new function for Python applications Feb 19, 2016
@dezgeg
Copy link
Contributor

dezgeg commented Feb 19, 2016

I guess the namePrefix = "" should be removed at the same time?

@FRidh FRidh closed this Feb 19, 2016
@FRidh
Copy link
Member Author

FRidh commented Feb 19, 2016

@dezgeg Good point. But that seems a bit harder to automate though.

@FRidh FRidh reopened this Feb 19, 2016
@dezgeg
Copy link
Contributor

dezgeg commented Feb 19, 2016

Maybe something like (untested):

for f in $(git diff --name-only); do
    sed -e '/namePrefix *=/d' -i $f
done

@FRidh
Copy link
Member Author

FRidh commented Feb 21, 2016

Will need to add buildPythonApplication to docs.

@FRidh FRidh added this to the 16.03 milestone Feb 21, 2016
@FRidh
Copy link
Member Author

FRidh commented Feb 23, 2016

Having namePrefix=""; inside buildPythonApplication is no problem. They can be removed later.

FRidh added a commit that referenced this pull request Feb 23, 2016
buildPythonApplication: use new function for Python applications
@FRidh FRidh merged commit 40ca841 into NixOS:master Feb 23, 2016
@FRidh FRidh deleted the buildPythonApplication branch February 23, 2016 15:02
@jgillich jgillich mentioned this pull request Mar 31, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants