Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python38: 3.8.9 -> 3.8.10; python39: 3.9.4 -> 3.9.5; python310: 3.10.0a5 -> 3.10.0b2 #127171

Merged
merged 3 commits into from
Jun 29, 2021

Conversation

mweinelt
Copy link
Member

Motivation for this change

CPython updates for python-unstable

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@FRidh
Copy link
Member

FRidh commented Jun 17, 2021

Thank you. Seems like I missed an e-mail. Note this should target staging. Please also build all Python passthru tests.

@mweinelt
Copy link
Member Author

mweinelt commented Jun 17, 2021

Okay, thanks for the pointers. python310.tests fails like this. Looking into that later tonight.

==================================== ERRORS ====================================
__________________ ERROR collecting ast3/tests/test_basics.py __________________
ImportError while importing test module '/build/source/ast3/tests/test_basics.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
/nix/store/hwaq99xsvx89y7p25njjq6nq2zm0qh9v-python3-3.10.0a5/lib/python3.10/importlib/__init__.py:126: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
ast3/tests/test_basics.py:5: in <module>
    from typed_ast import _ast3
E   ImportError: /nix/store/pz8kk94jvxdz8y73qzx2pxi94p6f0rbf-python3.10-typed-ast-1.4.3/lib/python3.10/site-packages/typed_ast/_ast3.cpython-310-x86_64-linux-gnu.so: undefined symbol: _PyArena_AddPyObject
=========================== short test summary info ============================
ERROR ast3/tests/test_basics.py
!!!!!!!!!!!!!!!!!!!! Interrupted: 1 error during collection !!!!!!!!!!!!!!!!!!!!
=============================== 1 error in 0.16s ===============================

We wanted to do a python-unstable run, would it be appropriate to retarget to python-unstable, or should it go to staging?

@FRidh
Copy link
Member

FRidh commented Jun 17, 2021

We wanted to do a python-unstable run, would it be appropriate to retarget to python-unstable, or should it go to staging?

No need, patch releases seldom cause any trouble.

Okay, thanks for the pointers. python310.tests fails like this. Looking into that later tonight.

That seem to be an upstream bug. I think we can ignore it.

@mweinelt mweinelt changed the base branch from master to staging June 17, 2021 15:10
@SuperSandro2000
Copy link
Member

@ofborg test python38 python39 python310

@mweinelt
Copy link
Member Author

@GrahamcOfBorg build python38.tests python39.tests pyton310.tests

@FRidh
Copy link
Member

FRidh commented Jun 18, 2021

3.10.0b3 is available now

@mweinelt
Copy link
Member Author

mweinelt commented Jun 18, 2021

Traceback (most recent call last):
  File "/nix/store/20xnnayviwdzxyjr7xyjq24wdpyplvj1-python3.10-pytest-6.2.3/bin/.py.test-wrapped", line 9, in <module>
    sys.exit(console_main())
  File "/nix/store/20xnnayviwdzxyjr7xyjq24wdpyplvj1-python3.10-pytest-6.2.3/lib/python3.10/site-packages/_pytest/config/__init__.py", line 185, in console_main
    code = main()
  File "/nix/store/20xnnayviwdzxyjr7xyjq24wdpyplvj1-python3.10-pytest-6.2.3/lib/python3.10/site-packages/_pytest/config/__init__.py", line 143, in main
    config = _prepareconfig(args, plugins)
  File "/nix/store/20xnnayviwdzxyjr7xyjq24wdpyplvj1-python3.10-pytest-6.2.3/lib/python3.10/site-packages/_pytest/config/__init__.py", line 318, in _prepareconfig
    config = pluginmanager.hook.pytest_cmdline_parse(
  File "/nix/store/h6ab8g2lflx023z2lif9wpvc6n3zphaw-python3.10-pluggy-0.13.1/lib/python3.10/site-packages/pluggy/hooks.py", line 286, in __call__
    return self._hookexec(self, self.get_hookimpls(), kwargs)
  File "/nix/store/h6ab8g2lflx023z2lif9wpvc6n3zphaw-python3.10-pluggy-0.13.1/lib/python3.10/site-packages/pluggy/manager.py", line 93, in _hookexec
    return self._inner_hookexec(hook, methods, kwargs)
  File "/nix/store/h6ab8g2lflx023z2lif9wpvc6n3zphaw-python3.10-pluggy-0.13.1/lib/python3.10/site-packages/pluggy/manager.py", line 84, in <lambda>
    self._inner_hookexec = lambda hook, methods, kwargs: hook.multicall(
  File "/nix/store/h6ab8g2lflx023z2lif9wpvc6n3zphaw-python3.10-pluggy-0.13.1/lib/python3.10/site-packages/pluggy/callers.py", line 203, in _multicall
    gen.send(outcome)
  File "/nix/store/20xnnayviwdzxyjr7xyjq24wdpyplvj1-python3.10-pytest-6.2.3/lib/python3.10/site-packages/_pytest/helpconfig.py", line 100, in pytest_cmdline_parse
    config: Config = outcome.get_result()
  File "/nix/store/h6ab8g2lflx023z2lif9wpvc6n3zphaw-python3.10-pluggy-0.13.1/lib/python3.10/site-packages/pluggy/callers.py", line 80, in get_result
    raise ex[1].with_traceback(ex[2])
  File "/nix/store/h6ab8g2lflx023z2lif9wpvc6n3zphaw-python3.10-pluggy-0.13.1/lib/python3.10/site-packages/pluggy/callers.py", line 187, in _multicall
    res = hook_impl.function(*args)
  File "/nix/store/20xnnayviwdzxyjr7xyjq24wdpyplvj1-python3.10-pytest-6.2.3/lib/python3.10/site-packages/_pytest/config/__init__.py", line 1003, in pytest_cmdline_parse
    self.parse(args)
  File "/nix/store/20xnnayviwdzxyjr7xyjq24wdpyplvj1-python3.10-pytest-6.2.3/lib/python3.10/site-packages/_pytest/config/__init__.py", line 1283, in parse
    self._preparse(args, addopts=addopts)
  File "/nix/store/20xnnayviwdzxyjr7xyjq24wdpyplvj1-python3.10-pytest-6.2.3/lib/python3.10/site-packages/_pytest/config/__init__.py", line 1168, in _preparse
    self.pluginmanager.consider_preparse(args, exclude_only=False)
  File "/nix/store/20xnnayviwdzxyjr7xyjq24wdpyplvj1-python3.10-pytest-6.2.3/lib/python3.10/site-packages/_pytest/config/__init__.py", line 635, in consider_preparse
    self.consider_pluginarg(parg)
  File "/nix/store/20xnnayviwdzxyjr7xyjq24wdpyplvj1-python3.10-pytest-6.2.3/lib/python3.10/site-packages/_pytest/config/__init__.py", line 660, in consider_pluginarg
    self.import_plugin(arg, consider_entry_points=True)
  File "/nix/store/20xnnayviwdzxyjr7xyjq24wdpyplvj1-python3.10-pytest-6.2.3/lib/python3.10/site-packages/_pytest/config/__init__.py", line 713, in import_plugin
    self.register(mod, modname)
  File "/nix/store/20xnnayviwdzxyjr7xyjq24wdpyplvj1-python3.10-pytest-6.2.3/lib/python3.10/site-packages/_pytest/config/__init__.py", line 443, in register
    self.consider_module(plugin)
  File "/nix/store/20xnnayviwdzxyjr7xyjq24wdpyplvj1-python3.10-pytest-6.2.3/lib/python3.10/site-packages/_pytest/config/__init__.py", line 669, in consider_module
    self._import_plugin_specs(getattr(mod, "pytest_plugins", []))
  File "/nix/store/20xnnayviwdzxyjr7xyjq24wdpyplvj1-python3.10-pytest-6.2.3/lib/python3.10/site-packages/_pytest/config/__init__.py", line 676, in _import_plugin_specs
    self.import_plugin(import_spec)
  File "/nix/store/20xnnayviwdzxyjr7xyjq24wdpyplvj1-python3.10-pytest-6.2.3/lib/python3.10/site-packages/_pytest/config/__init__.py", line 703, in import_plugin
    __import__(importspec)
  File "<frozen importlib._bootstrap>", line 1027, in _find_and_load
  File "<frozen importlib._bootstrap>", line 1006, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 688, in _load_unlocked
  File "/nix/store/20xnnayviwdzxyjr7xyjq24wdpyplvj1-python3.10-pytest-6.2.3/lib/python3.10/site-packages/_pytest/assertion/rewrite.py", line 161, in exec_module
    source_stat, co = _rewrite_test(fn, self.config)
  File "/nix/store/20xnnayviwdzxyjr7xyjq24wdpyplvj1-python3.10-pytest-6.2.3/lib/python3.10/site-packages/_pytest/assertion/rewrite.py", line 356, in _rewrite_test
    co = compile(tree, fn_, "exec", dont_inherit=True)
TypeError: required field "lineno" missing from alias
checking for finitel declaration... yes
builder for '/nix/store/5zfn4w2n1i8ij2lg5z44zpy38ycjzfqn-python3.10-pytest-6.2.3.drv' failed with exit code 1
error: build of '/nix/store/5zfn4w2n1i8ij2lg5z44zpy38ycjzfqn-python3.10-pytest-6.2.3.drv' on 'ssh://[email protected]' failed: builder for '/nix/store/5zfn4w2n1i8ij2lg5z44zpy38ycjzfqn-python3.10-pytest-6.2.3.drv' failed with exit code 1

@FRidh
Copy link
Member

FRidh commented Jun 18, 2021

Just ignore 3.10, its still beta and pytest probably needs to be fixed for it anyway.

@mweinelt
Copy link
Member Author

Okay, ignoring python310.tests, which is I think what you meant.

@jonringer
Copy link
Contributor

@GrahamcOfBorg build python39Packages.requests
@GrahamcOfBorg build python310Packages.requests
@GrahamcOfBorg build python38Packages.requests

@mweinelt
Copy link
Member Author

@GrahamcOfBorg build python38.tests python39.tests

@jonringer jonringer merged commit bb69640 into NixOS:staging Jun 29, 2021
@mweinelt mweinelt deleted the cpython branch June 29, 2021 14:56
@VergeDX
Copy link
Member

VergeDX commented Oct 5, 2021

@mweinelt Python 3.10.0 stable is now released! Time for packaging : )

@mweinelt
Copy link
Member Author

mweinelt commented Oct 5, 2021

@mweinelt Python 3.10.0 stable is now released! Time for packaging : )

#136254

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants