-
-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
podman: 3.1.2 -> 3.2.1 #125598
podman: 3.1.2 -> 3.2.1 #125598
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Not sure if we're supposed to have been shipping I'll continue with this PR tomorrow and I'll have a dig through the podman code then. |
Thank you! I expect that podman falls back to the internal seccomp profile (struct) if the file is not present on disk. So maybe this is a real regression, yes. |
Created containers/podman#10556 for tracking |
Thank you @saschagrunert! |
Oh, I should have looked at the logs sooner. I'd assumed the test failure was the same as the seccomp problem I ran into trying podman manually but it's a different error.
Bisected to containers/podman@0f7d54b. I'll file an issue about this upstream when I have time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@ofborg build podman.tests |
LGTM and tests are passing so I'm feeling fine about this one. cc @roberth as this release supposedly adds support for rootless |
https://github.com/containers/podman/releases/tag/v3.2.0
Motivation for this change
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nixos tests failing ...