Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/wireless: make wireless.interfaces mandatory #125288

Merged
merged 1 commit into from
Jun 6, 2021

Conversation

rnhmjoj
Copy link
Contributor

@rnhmjoj rnhmjoj commented Jun 1, 2021

Motivation for this change

This is the only way to solve issue #101963, for now.

Things done
  • Tested in 21.05
  • Built manual
  • Added a release notes entry if the change is major or breaking
  • Fits CONTRIBUTING.md.

This is the only way to solve issue NixOS#101963, for now.
@rnhmjoj rnhmjoj requested a review from ryantm as a code owner June 1, 2021 21:22
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` labels Jun 1, 2021
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Jun 1, 2021
@rnhmjoj rnhmjoj requested review from jonringer and dotlambda June 2, 2021 17:24
@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Jun 5, 2021

@jonringer Is updating the release notes after the release acceptable?

@jonringer
Copy link
Contributor

I would say it's okay.

I guess it's better to fail fast, so I'm okay backporting these changes as well

@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Jun 6, 2021

Ok, thank you. I'm merging now.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 6, 2021

Successfully created backport PR #125917 for release-21.05.

@Izorkin
Copy link
Contributor

Izorkin commented Jun 6, 2021

There are no wireless interfaces on the server. An error occurs while the system is rebuilding:

Failed assertions:
- No network interfaces for wpa_supplicant have been configured.
Please, specify at least one using networking.wireless.interfaces.

@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Jun 6, 2021

@Izorkin This assertion is behind a gate networking.wireless.enable. Are you sure it's not enabled somewhere in your configuration?

@Izorkin
Copy link
Contributor

Izorkin commented Jun 6, 2021

Checked, there is no parameter networking.wireless.enable

@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Jun 6, 2021

Maybe you have imported a file that enables it, like nixos/modules/profiles/installation-device.nix. Also try setting networking.wireless.enable = lib.mkForce false;.

@Izorkin
Copy link
Contributor

Izorkin commented Jun 7, 2021

Thanks, found here:

{ pkgs, ... }:
let
  netboot = import (pkgs.path + "/nixos/lib/eval-config.nix") {
      modules = [
        (pkgs.path + "/nixos/modules/installer/netboot/netboot-minimal.nix")
        module
      ];
    };
...

@rnhmjoj rnhmjoj deleted the wpa-race-fix branch July 10, 2023 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants