Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.hdbscan: disable another flaky test #124545

Merged
merged 1 commit into from
May 28, 2021
Merged

python3Packages.hdbscan: disable another flaky test #124545

merged 1 commit into from
May 28, 2021

Conversation

risicle
Copy link
Contributor

@risicle risicle commented May 26, 2021 •
edited
Loading

Motivation for this change

ZHF #122042

Failed on a release-21.05 build: https://nix-cache.s3.amazonaws.com/log/bbzm11pfrlfpp7zr1ih3ycl1vbmhxjrj-python3.9-hdbscan-0.8.27.drv

Seems known flaky scikit-learn-contrib/hdbscan#421

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Added a release notes entry if the change is major or breaking
  • Fits CONTRIBUTING.md.

@risicle risicle marked this pull request as ready for review May 26, 2021 21:30
@risicle risicle requested review from FRidh and jonringer as code owners May 26, 2021 21:30
@ofborg ofborg bot requested a review from ixxie May 26, 2021 21:34
@r-rmcgibbo
Copy link

r-rmcgibbo commented May 26, 2021 •
edited
Loading

Result of nixpkgs-review pr 124545 at 5bae3c6 run on x86_64-linux 1

2 packages built successfully:
  • python38Packages.hdbscan
  • python39Packages.hdbscan

Result of nixpkgs-review pr 124545 at 5bae3c6 run on aarch64-linux 1

2 packages built successfully:
  • python38Packages.hdbscan
  • python39Packages.hdbscan

fabaff
fabaff approved these changes May 28, 2021
View reviewed changes
Copy link
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good to me.

@fabaff fabaff merged commit 97eeca7 into NixOS:master May 28, 2021
@risicle risicle mentioned this pull request May 28, 2021
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabaff fabaff fabaff approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@ixxie ixxie Awaiting requested review from ixxie

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@risicle @r-rmcgibbo @fabaff