Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[21.05] nixos/kresd: tell resolveconf to use local resolver #124509

Merged
merged 1 commit into from
May 27, 2021

Conversation

dotlambda
Copy link
Member

Motivation for this change

backport #124391

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Added a release notes entry if the change is major or breaking
  • Fits CONTRIBUTING.md.

@dotlambda dotlambda changed the title nixos/kresd: tell resolveconf to use local resolver [21.05] nixos/kresd: tell resolveconf to use local resolver May 26, 2021
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels May 26, 2021
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels May 26, 2021
@vcunat
Copy link
Member

vcunat commented May 26, 2021

I wonder if this is small enough not to have a changelog mention. I'd probably leave it without any. (say, bind would be different because you can use it as authoritative-only server)

@SuperSandro2000 SuperSandro2000 merged commit 0a086ee into NixOS:release-21.05 May 27, 2021
@dotlambda dotlambda deleted the backport-124391 branch May 27, 2021 07:13
@ajs124
Copy link
Member

ajs124 commented May 27, 2021

this broke my setup. kthxbye.

for real though, not everyone has kresd listening on localhost.

@vcunat
Copy link
Member

vcunat commented May 28, 2021

Yes, I was aware that it isn't 100%, but it's not just kresd and it's trivial to override.

In any case, I'm curious about possible motivation to run a resolver but not use it for the local system.

@ajs124
Copy link
Member

ajs124 commented May 28, 2021

It is used on the local system, just not through 127.0.0.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants