Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

devpi-client, devpi-server: set __darwinAllowLocalNetworking #124428

Merged
merged 2 commits into from
May 26, 2021
Merged

devpi-client, devpi-server: set __darwinAllowLocalNetworking #124428

merged 2 commits into from
May 26, 2021

Conversation

risicle
Copy link
Contributor

@risicle risicle commented May 25, 2021 •
edited
Loading

Motivation for this change

ZHF #122042

Allowing tests to pass with sandbox enabled on darwin.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Added a release notes entry if the change is major or breaking
  • Fits CONTRIBUTING.md.

risicle added 2 commits May 25, 2021 22:01
@risicle
devpi-client: set __darwinAllowLocalNetworking
995d2d8 
allowing tests to pass on sandboxed darwin
@risicle
devpi-server: set __darwinAllowLocalNetworking
46e6661 
allowing tests to pass on sandboxed darwin
@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label May 25, 2021
@ofborg ofborg bot requested review from nlewo and makefu May 25, 2021 21:38
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels May 25, 2021
@risicle risicle mentioned this pull request May 25, 2021
Merged
9 tasks
@SuperSandro2000 SuperSandro2000 merged commit 34fb933 into NixOS:master May 26, 2021
@risicle risicle mentioned this pull request May 26, 2021
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nlewo nlewo Awaiting requested review from nlewo

@makefu makefu Awaiting requested review from makefu

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@risicle @SuperSandro2000