Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kube3d: 4.4.3 -> 4.4.4 #123699

Merged
merged 1 commit into from
May 23, 2021
Merged

kube3d: 4.4.3 -> 4.4.4 #123699

merged 1 commit into from
May 23, 2021

Conversation

06kellyjac
Copy link
Member

Motivation for this change

Bump kube3d to 4.4.4

Env var from last release is on by default, now k3d should run well on all nixos systems without extra faffing about

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from kalbasit, ngerstle, jlesquembre and kuznero May 19, 2021 16:06
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels May 19, 2021
@r-rmcgibbo
Copy link

Result of nixpkgs-review pr 123699 at c188351 run on x86_64-linux 1

2 packages built successfully:
  • kube3d
  • tests.trivial

@yurrriq
Copy link
Member

yurrriq commented May 20, 2021

It's unrelated to this PR, but I'm getting the following error. Any tips?

ERRO[0001] Failed Cluster Creation: Error response from daemon: container create: container-init binary not found on the host: stat /usr/libexec/podman/catatonit: no such file or directory

@06kellyjac
Copy link
Member Author

I'm going to need some lines above that to better understand where in the code that error appeared.

The long and the short of it is probably going to be Podman isn't supported yet by k3d: k3d-io/k3d#84

You could try disable the init cgroupsv2 fix that has been default turned on (by doing K3D_FIX_CGROUPV2=false) if it worked for previous versions, but if it's never worked before with k3d + podman for you then that k3d issue is the best place to follow for updates

@yurrriq
Copy link
Member

yurrriq commented May 20, 2021

Thanks, @06kellyjac, I think you're right, unfortunately. I've never used k3d before, so I can't speak to past success with podman. I'll try that variable. 🤞

@lukegb lukegb merged commit 554ed7e into NixOS:master May 23, 2021
@06kellyjac 06kellyjac deleted the kube3d branch May 23, 2021 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants