Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

systemd: 247.6 -> 248.3 #123476

Closed
wants to merge 1 commit into from
Closed

systemd: 247.6 -> 248.3 #123476

wants to merge 1 commit into from

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented May 18, 2021 •
edited
Loading

Motivation for this change

This should be not merged before the branch off the next release.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: systemd 8.has: module (update) This PR changes an existing module in `nixos/` labels May 18, 2021
@Mic92
Copy link
Member Author

Mic92 commented May 18, 2021

I had some tty issues still. Need to fix those on a different machine...

@Mic92 Mic92 marked this pull request as draft May 18, 2021 09:19
Mic92
Mic92 commented May 18, 2021
View reviewed changes
pkgs/os-specific/linux/systemd/default.nix
@@ -221,6 +216,16 @@ stdenv.mkDerivation {

# journalctl --grep requires libpcre so lets provide it
{ name = "libpcre2-8.so.0"; pkg = pcre2; }

# TODO: Support for TPM2 in systemd-cryptsetup, systemd-repart and systemd-cryptenroll
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also need to look into this...

@ofborg ofborg bot requested review from andir, edolstra, kloenk and flokli May 18, 2021 09:29
SuperSandro2000
SuperSandro2000 reviewed May 18, 2021
View reviewed changes
pkgs/os-specific/linux/systemd/default.nix
@@ -151,12 +152,6 @@ stdenv.mkDerivation {
./0017-path-util.h-add-placeholder-for-DEFAULT_PATH_NORMAL.patch
./0018-logind-seat-debus-show-CanMultiSession-again.patch
./0019-pkg-config-derive-prefix-from-prefix.patch

# Fix -Werror=format.
(fetchpatch {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the unused fetchpatch from inputs.

@dotlambda dotlambda mentioned this pull request May 20, 2021
Closed
10 tasks
@dotlambda
Copy link
Member

It would be nice to see the remaining issues solved and the PR merged soon since this update fixes systemd/systemd#19604.

@happysalada happysalada mentioned this pull request Jun 3, 2021
Closed
@globin
Copy link
Member

globin commented Jun 22, 2021

Any update on this? What are the current issues?

@SebTM
Copy link
Contributor

SebTM commented Jun 29, 2021

I'm also waiting for this because of the introduced feature "ActivationPolicy" - so I can manually manage when/which wireguard-connection should be up without rebuild. Please note that there is also another pull-request for system-upgrade (#119790)

@tijolao
Copy link

tijolao commented Jun 29, 2021

I think they are waiting 249 to be release, that I think is very close to happen.

@SebTM
Copy link
Contributor

SebTM commented Jun 29, 2021 •
edited
Loading

Thx for the information 👍🏻

@flokli
Copy link
Contributor

flokli commented Jul 3, 2021

I think @Mic92 referred to the nixos branchoff, which has already happened.

@Mic92 do you want to pick this up? I would prefer to stabilize 248 before jumping to 249, just haven't had enough of time recently :-)

@Mic92
Copy link
Member Author

Mic92 commented Jul 8, 2021

I am closing this for now to encourage someone else to pick it up. I am not sure when I would get to this. Feel free to pick up my process.

@Mic92 Mic92 closed this Jul 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@andir andir Awaiting requested review from andir

@edolstra edolstra Awaiting requested review from edolstra

@kloenk kloenk Awaiting requested review from kloenk

@flokli flokli Awaiting requested review from flokli

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: systemd 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 101-500 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Mic92 @dotlambda @globin @SebTM @tijolao @flokli @SuperSandro2000