Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

haskellPackages.gi-gtk-declarative: loosen haskell-gi version bound #122233

Closed
wants to merge 1 commit into from
Closed

haskellPackages.gi-gtk-declarative: loosen haskell-gi version bound #122233

wants to merge 1 commit into from

Conversation

divanorama
Copy link
Contributor

@divanorama divanorama commented May 8, 2021 •
edited
Loading

https://hydra.nixos.org/build/142721471/nixlog/1

owickstrom/gi-gtk-declarative#100

ZHF: #122042

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@divanorama divanorama changed the title haskellPackages.gi-gtk-declarative-app-simple: loosen haskell-gi version bound haskellPackages.gi-gtk-declarative: loosen haskell-gi version bound May 8, 2021
@r-rmcgibbo
Copy link

r-rmcgibbo commented May 8, 2021 •
edited
Loading

Result of nixpkgs-review pr 122233 at c0ae086 run on x86_64-linux 1

2 packages built successfully:
  • haskellPackages.gi-gtk-declarative
  • haskellPackages.gi-gtk-declarative-app-simple

Result of nixpkgs-review pr 122233 at c0ae086 run on aarch64-linux 1

2 packages built successfully:
  • haskellPackages.gi-gtk-declarative
  • haskellPackages.gi-gtk-declarative-app-simple

@jonringer
Copy link
Contributor

cc @NixOS/haskell

@sternenseemann
Copy link
Member

/rebase haskell-updates

@sternenseemann
Copy link
Member

Should be plenty of time to merge haskell-updates before branch off although I guess the feedback cycle is a bit suboptimal in the trunk jobset :/

@github-actions
Copy link
Contributor

github-actions bot commented May 8, 2021

Failed to rebase

@maralorn
Copy link
Member

maralorn commented May 8, 2021 •
edited
Loading

Thank you! I have cherry picked this on to haskell-updates.

@maralorn maralorn closed this May 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdepillabout cdepillabout Awaiting requested review from cdepillabout

@maralorn maralorn Awaiting requested review from maralorn

@sternenseemann sternenseemann Awaiting requested review from sternenseemann

Assignees
No one assigned
Labels
6.topic: haskell 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@divanorama @r-rmcgibbo @jonringer @sternenseemann @maralorn