-
-
Notifications
You must be signed in to change notification settings - Fork 15.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nyxt: 2020-10-23 -> 2021-03-27 #117902
nyxt: 2020-10-23 -> 2021-03-27 #117902
Conversation
alexandria | ||
bordeaux-threads | ||
calispel | ||
cl-css | ||
cl-json | ||
cl-markup | ||
cl-ppcre | ||
cl-ppcre-unicode | ||
cl-prevalence | ||
closer-mop | ||
cl-containers | ||
cluffer | ||
moptilities | ||
dexador | ||
enchant | ||
file-attributes | ||
iolib | ||
local-time | ||
log4cl | ||
mk-string-metrics | ||
osicat | ||
parenscript | ||
quri | ||
serapeum | ||
str | ||
plump | ||
swank | ||
trivia | ||
trivial-clipboard | ||
trivial-features | ||
trivial-package-local-nicknames | ||
trivial-types | ||
unix-opts | ||
cl-html-diff | ||
hu_dot_dwim_dot_defclass-star | ||
cl-custom-hash-table | ||
fset | ||
cl-cffi-gtk | ||
cl-webkit2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix this formatting.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, wrong autoindent applied, sorry
baseName = ''cl-custom-hash-table''; | ||
version = ''20201220-git''; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use " for single line strings.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, the change creates only one case of escape use in the quicklisp-to-nix output, so can as well regenerate.
Really excited for this! |
Thanks a lot, it's fantastic to see Nyxt in Nix again! :D Note: Osicat should no longer be necessary if you build Nyxt with SBCL. |
Thanks a lot, it's fantastic to see Nyxt in Nix again! :D
Well, Nyxt _was_ there, just too out of date (although still less out of date than the upstream release, so yeah)
Note: Osicat should no longer be necessary if you build Nyxt with SBCL.
I noticed that #- but decided to just keep it in (maybe it even works with CCL? I haven't tried)
Given the huge WebKit FFI-dependency, minor stuff like osicat does not look like worth optimising, especially with subsystem dependency lists hidden deeper inside etc.
|
I noticed that #- but decided to just keep it in (maybe it even works with CCL? I haven't tried)
It works with CCL indeed, but there are issues when dumping the image.
I need to work it out.
Given the huge WebKit FFI-dependency, minor stuff like osicat does not look like worth optimising, especially with subsystem dependency lists hidden deeper inside etc.
It's not just for size optimization but rather because osicat is a
tricky dependency to work with because it tries to compile files to its
directory when it's loaded.
This can be avoided if the package is carefully built. Just so you
know: if you run into issues with Osicat, feel free to remove it from
the Nyxt deps.
|
Thanks a lot! |
> Given the huge WebKit FFI-dependency, minor stuff like osicat does not look like worth optimising, especially with subsystem dependency lists hidden deeper inside etc.
It's not just for size optimization but rather because osicat is a
tricky dependency to work with because it tries to compile files to its
directory when it's loaded.
That part about compiling a .so into its directory is actually easy (and I need it to work for CL-Fuse / QueryFS anyway, so I will keep it working in Nixpkgs…). Funnily enough, there is some issue on CCL that it tries to force recompiling a part of trivial-features (works fine with SBCL, though).
|
nice to see an effort of getting nyxt build on nix! just tried this build via first two issues i found:
|
nice to see an effort of getting nyxt build on nix!
just tried this build via `nix run 'nixpkgs#nyxt'` from the latest nixpkgs master
I have no idea how many bugs there are in the choice of «which Nyxt» here…
first two issues i found:
- no TLS support available (TLS/SSL support not available; install glib-networking)
Under a fresh user works fine for me. This _does_ happen if I run «lispPackages.nyxt» version instead of top-level «nyxt» version, though
- fonts are too small and `zoom-in-page` doesnt increase them, only the rest of the page
Maybe the page uses some creative styling that WebKit refuses to scale? Does Midori behave the same?
|
I would expect that was the top-level nyxt running, what's the difference though? As for the font issue, that happened already on the nyxt help page (M-x help), which worked fine on the nyxt guix pack I downloaded before. |
I would expect that was the top-level nyxt running, what's the difference though?
The top-level application Nyxt is wrapped with all the GTK environment setup; lispPackages part is not.
As for the font issue, that happened already on the nyxt help page (M-x help), which worked fine on the nyxt guix pack I downloaded before.
Works for me. Also, isn't it C-space help instead of M-x help?
Have you tried it under a freshly-created empty user account?
(My testing was in a pretty restricted jail with empty but writeable $HOME)
|
OK the TLS issue is resolved now, not sure why it didn't work the first time, I'm running it the same way the top-level nyxt. The font issue is still there, though, perhaps it needs some extra env vars or font-config to find the fonts? It's not related to the local user profile, tried it in a few different ones where nyxt from the guix pack works fine, and other gtk apps work too. |
Oh, I have an Xorg-only setup, I guess that's why I am not seeing the font issue. Not even sure at what level the problem is — font scaling is fine in Midori with Wayland, right? |
fonts in midori work fine both with wayland and x11 |
Then I am lost… Not sure which part should behave differently between X11 and GTK and not be used by Midori. |
Motivation for this change
Nyxt was too old, some changes needed to build a newer one
Will eventually self-merge
@atlas-engineer @nlewo @bqv
Things done
sandbox
innix.conf
on non-NixOS linux)./result/bin/
)