Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nyxt: 2020-10-23 -> 2021-03-27 #117902

Merged
merged 2 commits into from
Mar 30, 2021
Merged

nyxt: 2020-10-23 -> 2021-03-27 #117902

merged 2 commits into from
Mar 30, 2021

Conversation

7c6f434c
Copy link
Member

Motivation for this change

Nyxt was too old, some changes needed to build a newer one

Will eventually self-merge

@atlas-engineer @nlewo @bqv

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@r-rmcgibbo
Copy link

Result of nixpkgs-review pr 117902 at c10b36b run on x86_64-linux 1

3 packages built successfully:
  • lispPackages.cl-custom-hash-table
  • lispPackages.nyxt
  • nyxt

Comment on lines 145 to 183
alexandria
bordeaux-threads
calispel
cl-css
cl-json
cl-markup
cl-ppcre
cl-ppcre-unicode
cl-prevalence
closer-mop
cl-containers
cluffer
moptilities
dexador
enchant
file-attributes
iolib
local-time
log4cl
mk-string-metrics
osicat
parenscript
quri
serapeum
str
plump
swank
trivia
trivial-clipboard
trivial-features
trivial-package-local-nicknames
trivial-types
unix-opts
cl-html-diff
hu_dot_dwim_dot_defclass-star
cl-custom-hash-table
fset
cl-cffi-gtk
cl-webkit2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix this formatting.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, wrong autoindent applied, sorry

Comment on lines 3 to 4
baseName = ''cl-custom-hash-table'';
version = ''20201220-git'';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use " for single line strings.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, the change creates only one case of escape use in the quicklisp-to-nix output, so can as well regenerate.

@jmercouris
Copy link

Really excited for this!

@7c6f434c 7c6f434c merged commit 377e92d into NixOS:master Mar 30, 2021
@Ambrevar
Copy link

Thanks a lot, it's fantastic to see Nyxt in Nix again! :D

Note: Osicat should no longer be necessary if you build Nyxt with SBCL.

@7c6f434c
Copy link
Member Author

7c6f434c commented Mar 30, 2021 via email

@Ambrevar
Copy link

Ambrevar commented Mar 30, 2021 via email

@jmercouris
Copy link

Thanks a lot!

@7c6f434c
Copy link
Member Author

7c6f434c commented Mar 30, 2021 via email

@tg-x
Copy link
Member

tg-x commented Apr 1, 2021

nice to see an effort of getting nyxt build on nix!

just tried this build via nix run 'nixpkgs#nyxt' from the latest nixpkgs master

first two issues i found:

  • no TLS support available (TLS/SSL support not available; install glib-networking)
  • fonts are too small when using Wayland, and zoom-in-page doesnt increase them, only the rest of the page (with Xwayland fonts are OK)

@7c6f434c
Copy link
Member Author

7c6f434c commented Apr 1, 2021 via email

@tg-x
Copy link
Member

tg-x commented Apr 3, 2021

I would expect that was the top-level nyxt running, what's the difference though?

As for the font issue, that happened already on the nyxt help page (M-x help), which worked fine on the nyxt guix pack I downloaded before.

@7c6f434c
Copy link
Member Author

7c6f434c commented Apr 3, 2021 via email

@tg-x
Copy link
Member

tg-x commented Apr 3, 2021

OK the TLS issue is resolved now, not sure why it didn't work the first time, I'm running it the same way the top-level nyxt.

The font issue is still there, though, perhaps it needs some extra env vars or font-config to find the fonts?
It only happens with GDK_BACKEND=wayland but not with GDK_BACKEND=x11

It's not related to the local user profile, tried it in a few different ones where nyxt from the guix pack works fine, and other gtk apps work too.

@7c6f434c
Copy link
Member Author

7c6f434c commented Apr 3, 2021

Oh, I have an Xorg-only setup, I guess that's why I am not seeing the font issue.

Not even sure at what level the problem is — font scaling is fine in Midori with Wayland, right?

@tg-x
Copy link
Member

tg-x commented Apr 3, 2021

fonts in midori work fine both with wayland and x11
(the toolbar icons are missing though in both cases)

@7c6f434c
Copy link
Member Author

7c6f434c commented Apr 4, 2021

Then I am lost… Not sure which part should behave differently between X11 and GTK and not be used by Midori.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants