Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

haskellPackages.hnix-store-core: 0.4.2.0 #116089

Merged
merged 1 commit into from
Mar 15, 2021
Merged

haskellPackages.hnix-store-core: 0.4.2.0 #116089

merged 1 commit into from
Mar 15, 2021

Conversation

Anton-Latukha
Copy link
Contributor

@Anton-Latukha Anton-Latukha commented Mar 12, 2021 •
edited
Loading

Third time the charm.

Motivation for this change

Release just being made, so patch applies after Hackage update.
The tasty-discover no longer applies, it is properly added to build-tool-depends:.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Anton-Latukha
haskellPackages.hnix-store-core: 0.4.2.0
5623131 
Release just was made, fixed the `tasty-discover`.
@r-rmcgibbo
Copy link

Result of nixpkgs-review pr 116089 at 5623131 run on x86_64-linux 1

41 packages marked as broken and skipped:
  • agdaPackages.iowa-stdlib
  • bareos
  • hyper-haskell
  • hyper-haskell-server-with-packages
  • idrisPackages.descncrunch
  • idrisPackages.sdl
  • ihaskell
  • librsb
  • libsForQt512.discover
  • libsForQt514.discover
  • ...
1532 packages skipped due to time constraints:
  • EBTKS
  • agda (agdaPackages.agda)
  • agdaPackages.agda-categories
  • agdaPackages.agda-prelude
  • agdaPackages.cubical
  • agdaPackages.functional-linear-algebra
  • agdaPackages.generic
  • agdaPackages.standard-library
  • apostrophe
  • archivy
  • ...
84 packages built successfully:

@sternenseemann
Copy link
Member

We still are on hnix-store-core 0.4.1.0 in haskell-updates, but with the next package set rebuild we should get it (unless it's also part of stackage?).

@Anton-Latukha
Copy link
Contributor Author

Anton-Latukha commented Mar 12, 2021 •
edited
Loading

Package on Stackage LTS is 0.2, but the package was removed from Nightly, so, This is fine:

wrapper

Screenshot-2021-03-12-23:05:34

sternenseemann
sternenseemann approved these changes Mar 14, 2021
View reviewed changes
Copy link
Member

@sternenseemann sternenseemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hnix-store-core is now on haskell-updates && compiles without the override.

@cdepillabout
Copy link
Member

@GrahamcOfBorg build haskellPackages.hnix-store-core

@cdepillabout
Copy link
Member

LGTM, thanks!

@sternenseemann Thanks for reviewing as well

@cdepillabout cdepillabout merged commit 3a596b1 into NixOS:haskell-updates Mar 15, 2021
@Anton-Latukha Anton-Latukha deleted the update branch March 15, 2021 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sternenseemann sternenseemann sternenseemann approved these changes

@cdepillabout cdepillabout Awaiting requested review from cdepillabout

Assignees
No one assigned
Labels
6.topic: haskell 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Anton-Latukha @r-rmcgibbo @sternenseemann @cdepillabout