build-fhs-userenv: don't leak file descriptors #11602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This re-uses the capabilities documented in `Process.spawn` to avoid leaking unecessary file-descriptors to the sandbox
|
By analyzing the blame information on this pull request, we identified @abbradar and @lethalman to be potential reviewers |
aristidb
added
0.kind: enhancement
|
I added label WIP because you didn't test this yet. |
abbradar
added a commit
that referenced
this pull request
Dec 10, 2015
build-fhs-userenv: don't leak file descriptors
|
Tested with |
This was referenced Nov 4, 2022
This was referenced Nov 28, 2023
This was referenced May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This re-uses the capabilities documented in
Process.spawnto avoid leakingunecessary file-descriptors to the sandbox
I haven't tested the changes yet