Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.diskcache: 5.1.0 -> 5.2.1, python3Packages.pandas: 1.2.2 -> 1.2.3 #114473

Merged
merged 2 commits into from
Mar 6, 2021
Merged

python3Packages.diskcache: 5.1.0 -> 5.2.1, python3Packages.pandas: 1.2.2 -> 1.2.3 #114473

merged 2 commits into from
Mar 6, 2021

Conversation

fabaff
Copy link
Member

@fabaff fabaff commented Feb 26, 2021

Motivation for this change

Update to latest upstream release 5.2.1

Commit log: https://github.com/grantjenks/python-diskcache/commits/v5.2.1

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from costrouc February 26, 2021 15:40
@r-rmcgibbo
Copy link

r-rmcgibbo commented Feb 26, 2021 •
edited
Loading

Result of nixpkgs-review pr 114473 at d46f0a54 run on x86_64-linux 1

3 packages failed to build:
3 packages built:
1 suggestion:
  • warning: unused-argument

    Unused argument: django.
    Near pkgs/development/python-modules/diskcache/default.nix:10:3:

       |
10 | , django
   |   ^

Result of nixpkgs-review pr 114473 at d46f0a54 run on aarch64-linux 1

1 package failed to build:
5 packages built:
1 suggestion:
  • warning: unused-argument

    Unused argument: django.
    Near pkgs/development/python-modules/diskcache/default.nix:10:3:

       |
10 | , django
   |   ^

@fabaff fabaff marked this pull request as draft February 26, 2021 18:02
@ofborg ofborg bot requested review from 7c6f434c and knedlsepp February 26, 2021 19:37
@fabaff fabaff changed the title python3Packages.diskcache: 5.1.0 -> 5.2.1 python3Packages.diskcache: 5.1.0 -> 5.2.1, python3Packages.pandas: 1.1.5 -> 1.2.2 Feb 27, 2021
@SuperSandro2000 SuperSandro2000 added the 2.status: merge conflict This PR has merge conflicts with the target branch label Mar 1, 2021
@SuperSandro2000
Copy link
Member

@fabaff please resolve the merge conflict.

@FRidh
Copy link
Member

FRidh commented Mar 1, 2021

Please target staging-next. When pandas 1.2.2 is fixed there it can go into master. Note 1.2.3 is to be released soon.

@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Mar 1, 2021
@fabaff fabaff marked this pull request as ready for review March 1, 2021 21:32
@fabaff
Copy link
Member Author

fabaff commented Mar 3, 2021

/rebase staging-next

@github-actions github-actions bot changed the base branch from master to staging-next March 3, 2021 06:43
@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2021

Rebased, please reopen the pull request to restart CI

@github-actions github-actions bot closed this Mar 3, 2021
@fabaff fabaff reopened this Mar 3, 2021
@ofborg ofborg bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Mar 3, 2021
@SuperSandro2000 SuperSandro2000 mentioned this pull request Mar 3, 2021
Open
@fabaff fabaff mentioned this pull request Mar 5, 2021
Closed
10 tasks
@fabaff fabaff changed the title python3Packages.diskcache: 5.1.0 -> 5.2.1, python3Packages.pandas: 1.1.5 -> 1.2.2 python3Packages.diskcache: 5.1.0 -> 5.2.1, python3Packages.pandas: 1.1.5 -> 1.2.3 Mar 5, 2021
@mweinelt
Copy link
Member

mweinelt commented Mar 5, 2021

@fabaff Did you forgot to push the change?

@fabaff
Copy link
Member Author

fabaff commented Mar 5, 2021

No, I didn't. Building locally takes time. Want to make sure that all tests are passing because of the update from 1.2.2 to 1.2.3.

@fabaff fabaff changed the title python3Packages.diskcache: 5.1.0 -> 5.2.1, python3Packages.pandas: 1.1.5 -> 1.2.3 python3Packages.diskcache: 5.1.0 -> 5.2.1, python3Packages.pandas: 1.2.2 -> 1.2.3 Mar 5, 2021
@fabaff
Copy link
Member Author

fabaff commented Mar 5, 2021

Result of nixpkgs-review pr 114473 run on x86_64-linux 1

1 package built:
  • python3Packages.pandas

@fabaff
Copy link
Member Author

fabaff commented Mar 5, 2021

Before I forget it: Huge thanks to everybody here for the patience and the input.

@FRidh FRidh merged commit dd567e6 into NixOS:staging-next Mar 6, 2021
@FRidh
Copy link
Member

FRidh commented Mar 6, 2021

Great work, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mweinelt mweinelt mweinelt requested changes

@jtojnar jtojnar jtojnar left review comments

@SuperSandro2000 SuperSandro2000 SuperSandro2000 requested changes

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@costrouc costrouc Awaiting requested review from costrouc

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

@knedlsepp knedlsepp Awaiting requested review from knedlsepp

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 501-1000 10.rebuild-darwin: 501+ 10.rebuild-linux: 501-1000 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@fabaff @r-rmcgibbo @SuperSandro2000 @FRidh @mweinelt @jtojnar