Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3.pkgs.osmpythontools: 0.2.8 -> 0.2.9 #111847

Merged
merged 2 commits into from
Feb 4, 2021
Merged

python3.pkgs.osmpythontools: 0.2.8 -> 0.2.9 #111847

merged 2 commits into from
Feb 4, 2021

Conversation

das-g
Copy link
Member

@das-g das-g commented Feb 4, 2021 •
edited
Loading

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix run nixpkgs.nixpkgs-review -c nixpkgs-review pr 111847 --post-result
  • Tested execution of all binary files (usually in ./result/bin/)
    • (there are no executable files, as this is a library)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@das-g das-g requested review from FRidh and jonringer as code owners February 4, 2021 00:23
@das-g
Copy link
Member Author

das-g commented Feb 4, 2021

Result of nixpkgs-review pr 111847 run on x86_64-linux 1

2 packages built:
  • python37Packages.osmpythontools
  • python38Packages.osmpythontools

@ofborg ofborg bot added 6.topic: python 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Feb 4, 2021
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 111847 run on x86_64-darwin 1

2 packages built:
  • python37Packages.osmpythontools
  • python38Packages.osmpythontools

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 111847 run on x86_64-linux 1

2 packages built:
  • python37Packages.osmpythontools
  • python38Packages.osmpythontools

@SuperSandro2000 SuperSandro2000 merged commit fa6a0a0 into NixOS:master Feb 4, 2021
@das-g das-g deleted the osmpythontools branch April 2, 2022 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@das-g @SuperSandro2000