-
-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
emacsPackages*: Move to emacs*.pkgs #107152
emacsPackages*: Move to emacs*.pkgs #107152
Conversation
a51ce6c
to
7c76e9c
Compare
This is the reason we have with Python |
No reason python3.withPackages couldn't be the endorsed way, no? |
Maybe I wasn't clear enough. With the approach in this PR, one has to use |
Related PR for PHP #107044. We really need to converge on a single interface here (partially NixOS/rfcs#67). |
Wrote a draft for an RFC on this topic NixOS/rfcs#83. |
This makes it much easier to create customisations around emacs via the a new convenience passthru attr: - `emacs.pkgs`: What used to be emacsPackages is now `emacs.pkgs` The previous versioned names `emacs*Packages` have been moved to aliases.nix and are now considered deprecated in favour of `emacs*.pkgs`.
…gs.withPackages The previous names are now aliases and shouldn't be used anywhere inside nixpkgs.
7c76e9c
to
4003f8c
Compare
@adisbladis and I had a short chat. RFC 83 will still take a while, and this follows the spirit of it very closely. The most invasive possible change would likely be |
Motivation for this change
This makes it much easier to create customisations around emacs via
the two new convenience passthru attrs:
emacs.pkgs.withPackages
: likeemacsWithPackages
but now exists on all emacsen derivationsemacs.pkgs
: What used to be emacsPackages is nowemacs.pkgs
The previous versioned names
emacs*Packages
have been moved toaliases.nix and are now considered deprecated in favour of
emacs*.pkgs
.I believe that it's much easier to use this API correctly than the previous API.
I also believe that this provides a much better UX which is more symmetrical (the
-nox
derivations did not have package sets available, so if you wanted to useemacsWithPackages
with them you had to figure it out on your own), but I'm open to inputs on something I might have missed or other perspectives.Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)cc @etu @bqv @alyssais @bendlas @tadfisher
Also cc @FRidh for how this possibly could be replicated for the Python package sets (to be clear I'm talking about deprecation of the
python*Packages
names).