Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/acme: Permissions and tests fixes #101370

Merged
merged 2 commits into from
Oct 28, 2020
Merged

nixos/acme: Permissions and tests fixes #101370

merged 2 commits into from
Oct 28, 2020

Conversation

m1cr0man
Copy link
Contributor

This PR follows from extended discussion in #91121. In particular:

  • A permissions issue was highlighted where the chmod used to fix old certificate permissions was a bit too far scoped, and set executable perms on cert files.
  • @aszlig highlighted that generating certs during tests with minica can cause issues with regards to mismatching derivations between a cache and a local build. They are now hard coded.

@NixOS/acme, and @lheckemann as they suggested the new chmod arguments 🙂 .

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@m1cr0man
nixos/acme: Use more secure chmods
89d134b 
Previous settings would make files executable in
the certs directories.
@m1cr0man
nixos/tests/acme: Hard code test certificates
dad06fb 
The added README.md explains why this has been done.
@ofborg ofborg bot added the ofborg-internal-error Ofborg encountered an error label Oct 22, 2020
@cole-h cole-h removed the ofborg-internal-error Ofborg encountered an error label Oct 23, 2020
@cole-h
Copy link
Member

cole-h commented Oct 23, 2020

@ofborg eval

@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Oct 23, 2020
@lheckemann
Copy link
Member

@ofborg test acme

@lheckemann lheckemann merged commit 2b06415 into NixOS:master Oct 28, 2020
@lheckemann
Copy link
Member

This should probably be backported, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lheckemann lheckemann lheckemann approved these changes

@aszlig aszlig aszlig approved these changes

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@m1cr0man @cole-h @lheckemann @aszlig