networkmanager-sstp: init at unstable-2020-04-20, bump sstp from 1.0.12 to 1.0.13 #100657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flokli
force-pushed
the
network-manager-sstp
branch
from
60d8a4c to
5a331d8
Compare
ofborg
bot
added
6.topic: nixos
ofborg
bot
requested review from
Phreedom,
domenkozar,
worldofpeace and
obadz
ofborg
bot
added
10.rebuild-darwin: 0
lovesegfault
approved these changes
Oct 20, 2020
There was a problem hiding this comment.
Left a minor nit.
I wish this was made optional, but perhaps that has to happen whenever we make all of NM's plugins optional
c.f. #84433
Comment on lines
1
to
2
| { stdenv, fetchFromGitHub, substituteAll, autoreconfHook, sstp, ppp, file, intltool, pkgconfig, networkmanager, libsecret, gtk3 | ||
| , withGnome ? true, gnome3, fetchpatch, libnma, glib }: |
There was a problem hiding this comment.
Wish this was split over a few lines
flokli
force-pushed
the
network-manager-sstp
branch
from
5a331d8 to
e992089
Compare
|
Okay, let's get this in, and work on making it optional in #84433, together with all the other plugins. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Connecting to SSTP VPNs without manually working with sstpc.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)