Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/doc: Mention fontconfig changes in 20.09 RN #100103

Merged
merged 1 commit into from
Oct 10, 2020
Merged

nixos/doc: Mention fontconfig changes in 20.09 RN #100103

merged 1 commit into from
Oct 10, 2020

Conversation

jtojnar
Copy link
Member

@jtojnar jtojnar commented Oct 9, 2020

Motivation for this change

cc #95765

This is a major change but it should not cause any issues.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested that docs render correctly
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jtojnar
nixos/doc: Mention fontconfig changes in 20.09 RN
be2f1cb 
This is a major change but it should not cause any issues.
@worldofpeace worldofpeace added this to the 20.09 milestone Oct 9, 2020
@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog 8.has: documentation This PR adds or changes documentation 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Oct 9, 2020
@jtojnar jtojnar mentioned this pull request Oct 9, 2020
Closed
10 tasks
worldofpeace
worldofpeace approved these changes Oct 10, 2020
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@worldofpeace worldofpeace merged commit 38237e9 into NixOS:master Oct 10, 2020
@worldofpeace worldofpeace deleted the fontconfig-rn branch October 10, 2020 20:47
@worldofpeace
Copy link
Contributor

worldofpeace commented Oct 10, 2020 •
edited
Loading

backported in dd03915

@worldofpeace
Copy link
Contributor

Thanks for fixing this @jtojnar 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace approved these changes

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog 8.has: documentation This PR adds or changes documentation 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
20.09
Development

Successfully merging this pull request may close these issues.
2 participants
@jtojnar @worldofpeace