Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

20.09 Feature freeze items #95475

Closed
jonringer opened this issue Aug 15, 2020 · 40 comments
Closed

20.09 Feature freeze items #95475

jonringer opened this issue Aug 15, 2020 · 40 comments
Labels
0.kind: enhancement Add something new 6.topic: release process Issues or PRs which are parts of the NixOS release process

Comments

@jonringer
Copy link
Contributor

jonringer commented Aug 15, 2020

Pinging all language, framework, and ecosystem owners to consolidate feature freeze items for the 20.09 release.

Please mention any items you see blocking the 20.09 release in your given domains

Items brought up will be discussed in a Feature freeze meeting at a later date.

Nix/nix-cli ecosystem: @edolstra @grahamc @nbp @Profpatsch
Mobile: @samueldr
Nixos Modules / internals : @infinisil @matthewbauer @Ericson2314 @orivej
Nixos tests: @tfc

Emacs: @adisbladis
Erlang: @gleber
Go: @kalbasit @Mic92 @zowoq
Haskell: @peti @cdepillabout
Python: @FRidh
Perl: @volth
php: @NixOS/php
Ruby: @alyssais
rust: @bhipple @Mic92 @andir @LnL7

Darwin: @NixOS/darwin-maintainers

bazel: @mboes
blockchains @mmahut
podman: @NixOS/podman
Qt / KDE: @ttuegel
Postgres: @thoughtpolice

Co-release-manager: @worldofpeace

in case I forgot anyone: @NixOS/nixpkgs-committers

If I did forget someone, please cc them. I would like to make sure that everyone was able to voice their concerns and issues.

@jonringer jonringer added 0.kind: bug Something is broken 0.kind: enhancement Add something new and removed 0.kind: bug Something is broken labels Aug 15, 2020
@cdepillabout
Copy link
Member

cc @maralorn about Haskell stuff as well.

@vcunat
Copy link
Member

vcunat commented Aug 15, 2020

Roughly it should be master around the end of August as usual, right?

@jonringer
Copy link
Contributor Author

Our current plan is to have the branch-off + ZHF date on 4 Sept. I'll make a more official roadmap announcement tomorrow.

@arianvp
Copy link
Member

arianvp commented Aug 15, 2020

#94354 is blocking

@aanderse
Copy link
Member

Looks like zabbix.server-mysql and zabbix.server-pgsql broke recently: https://hydra.nixos.org/build/122059780. I briefly poked around but I'm not sure what the problem or solution is. If anyone has any insight much appreciated.

@jonringer
Copy link
Contributor Author

@aanderse It tries to compile a small program against libxml2, but fails to do so; although the PKG_CONFIG_PATH appears to contain libxml2.

It can be fixed short term by removing libxml2, but I'm not sure if that's acceptable for the server

@etu
Copy link
Contributor

etu commented Aug 15, 2020

Just to mention it as a representative/maintainer of the php ecosystem. We've recently merged our deprecation of on old version that should be merged before 20.09. So for the php ecosystem we're good to go.

Consider this message a confirmation that someone read the ping to that team in the posting.

@bhipple
Copy link
Contributor

bhipple commented Aug 15, 2020

Not aware of any major outstanding blocking issues in the Rust ecosystem. The staging branch moves rustc 1.45.0 -> 1.45.2, which is the latest; I'm assuming we'll get at least 1 more staging -> master merge before branch-off.

@jonringer
Copy link
Contributor Author

I'm assuming we'll get at least 1 more staging -> master merge before branch-off.

That should be the case

@aanderse
Copy link
Member

@aanderse It tries to compile a small program against libxml2, but fails to do so; although the PKG_CONFIG_PATH appears to contain libxml2.

It can be fixed short term by removing libxml2, but I'm not sure if that's acceptable for the server

@jonringer unfortunately that would remove functionality (automatic vmware monitoring) that some users may find important. I personally don't use that functionality, so I would accept that over a broken build... I have opened a separate issue to track this.

@aanderse
Copy link
Member

Another issue which needs resolution one way or the other: #94022.

ping @grahamc @flokli @arianvp @andir @blitz @primeos

@worldofpeace
Copy link
Contributor

According to the GNOME 3.38.0 roadmap https://wiki.gnome.org/ThreePointThirtyseven it's due Sep 16. So I believe this means we won't have the latest GNOME in the release. This is fine since we basically never do because our release time conflicts with theirs always.

@worldofpeace
Copy link
Contributor

It was projected that xfce 4.16 would be available before 20.09 release, but it seems they need more time in their roadmap #81569. So xfce 4.16 will not be in 20.09.

@worldofpeace worldofpeace pinned this issue Aug 17, 2020
@bjornfor
Copy link
Contributor

So I believe this means we won't have the latest GNOME in the release. This is fine since we basically never do because our release time conflicts with theirs always.

Why don't we release NixOS one month later? This will sync up with Ubuntu too.

@vcunat
Copy link
Member

vcunat commented Aug 17, 2020

Could be, but there are many projects that we package, and so far I haven't noticed that a notable fraction of them synchronizes around some dates (like the Ubuntu schedule).

EDIT: though perhaps this synchronization will happen – I see Fedora basically shifting to Ubuntu's schedule now (no idea if it's intentional).

@Atemu
Copy link
Member

Atemu commented Aug 17, 2020

@worldofpeace do you know how big the GNOME breakage would be?
If it's not too bad I don't see why we couldn't just backport it after release.

@vcunat
Copy link
Member

vcunat commented Aug 17, 2020

Generally I wouldn't do such things, and for desktops in particular I don't anticipate sufficient motivation for doing that. Regardless of release dates, there's a notable advantage we have in comparison to the Ubuntu model: we do provide quite a usable rolling version. People that want the latest whatever can use nixos-unstable channel (which still gives some automatic-testing assurances).

@jonringer
Copy link
Contributor Author

Why don't we release NixOS one month later? This will sync up with Ubuntu too.

I'm not sure if that's a good reason to push a date. Unless KDE, gnome, and the other big software suites decides to align themselves for that type of schedule, then may it would make sense for us to change so we could have the "latest" going into a release.

However, it also takes time for downstream packages to fully support those versions, and it still takes time to ensure they are working as intended. It's going to be hit or miss whether a given month really affords any substantial opportunities given there's so many packages, and not everyone cares certain sets. For example, I don't use a DE, so I largely am unaffected by KDE, plasma, gnome, or other changes.

And as @vcunat has mentioned, we have a very usable "unstable" channel if people really care about having the latest and greatest.

And one thing NixOS can do which other distros usually cannot, is allow for a user to pick packages from different channels. (although, this is much more involved for a regular user)

@Mic92
Copy link
Member

Mic92 commented Aug 17, 2020

And one thing NixOS can do which other distros usually cannot, is allow for a user to pick packages from different channels. (although, this is much more involved for a regular user)

This become less involved with flakes.

@worldofpeace
Copy link
Contributor

@worldofpeace do you know how big the GNOME breakage would be?

The amount of breakage when updating gnome can vary, but in general updating desktop environments etc. in nixos is very difficult because we don't really have an automatic testing to verify. Here's an excellent example of this issue #84634 (comment). There are bugs we haven't noticed for a while because it's a thing I don't use.
So I'm actually thankful we'll have 3.36 on stable, which is something that has been checked up on for a while now.

If it's not too bad I don't see why we couldn't just backport it after release.

That is a major upgrade, and generally, in a stable distribution, it is something that couldn't be backported.
After 20.09 is released it's totally "feature frozen". So that would be a bunch of UI/UX changes breaking the freeze.

Why don't we release NixOS one month later? This will sync up with Ubuntu too.

As for ever pushing our release a month forward to accommodate gnome's release (which happens in the *.03 in *.09 exactly btw), this still wouldn't be enough time because we lack the resources. I would agree with most things @jonringer mentioned #95475 (comment), but I do understand for a general user pov accommodating to have the latest just makes sense. I think changing the actual dates in which we "consistently try to aim for" should be done with a lot of reasoning. Though let's be real: NixOS 20.03 was a NixOS 20.04. But pushing the date to the month we actually are releasing on isn't going to make us more punctual either 🤣 .
Anyways, I think this a discussion better had at #95535.
My principle for changing things up is we should do smaller but still impacting and meaningful changes. See #95535 (Changes from last year). We have to remember that someone new is going to have to duplicate this process in six months and still produce a consistent experience.

@adisbladis
Copy link
Member

I see #87268 as blocking. I would love some input on what a good solution is (in the PR).

@NeQuissimus
Copy link
Member

I'd like to see the systemd updates from staging make it into master, so we can bring back the 5.8.x kernel.

@vcunat
Copy link
Member

vcunat commented Aug 17, 2020

That one is very certain.

@mweinelt
Copy link
Member

mweinelt commented Aug 17, 2020

I wonder what the @NixOS/acme team thinks about supporting the current ACME module for another release, when it would probably be best to be investing in #91121 asap.

@m1cr0man
Copy link
Contributor

I wonder what the @NixOS/acme team thinks about supporting the current ACME module for another release, when it would probably be best to be investing in #91121 asap.

I for one would very much like to see it merged. Maintaining the "old" module continues to get more painful as more patches and bug fixes are added to address legacy behaviour. I've addressed all the issues I could find in Github and elsewhere, and having had it in production on my personal system for quite a while I haven't had a single renewal issue.

@jonringer
Copy link
Contributor Author

To avoid spamming everyone with yet another issue, please add release items that are not in the current 20.09 release notes in the issue: #95765

@rnhmjoj
Copy link
Contributor

rnhmjoj commented Aug 22, 2020

Uh, it looks like we forgot about loaOf (issue #77189). We should really remove it now: it has been deprecated for since 20.03 and all the deprecated usages withing Nixpkgs should have been already fixed.

@samueldr
Copy link
Member

samueldr commented Aug 22, 2020

Not a blocker, but a TODO item once branched-off:

  • Remove the Raspberry Pi 4 image generation from 20.09 post branch-off

That image was supposed to be temporary on unstable, up until mainline Linux was able to boot on the Raspberry Pi 4, which is still not the case AFAIK.

@Atemu
Copy link
Member

Atemu commented Aug 30, 2020

Shouldn't we rather fix the image by putting the RPI kernel Fork in it instead of mainline?

@samueldr
Copy link
Member

Shouldn't we rather fix the image by putting the RPI kernel Fork in it instead of mainline?

Putting the RPI kernel fork in what? This is what the Raspberry Pi 4-specific image does already. The task is to remove the undesirable device-specific image from the stable channel.

The sd image, by design, is supposed to be generic. The current Raspberry Pi 4-specific sd image derivation only exists because of the popularity of the platform, and demand. I still hold the opinion that it might have been a mistake to have it at all. If the platform can't boot using the standard boot methods (u-boot) and the mainline kernel, for the time being it's not worth the headaches of maintaining it in an official manner.

@jonringer
Copy link
Contributor Author

I'm unpinning this as many of the items have been merged in before branch off, if they have not please add them to the 20.09 blocker project

@jonringer jonringer unpinned this issue Sep 8, 2020
@jonringer
Copy link
Contributor Author

I'm going to re-pin this, as many items have been added, but few have seen progress in the past 3 weeks.

Items that feel like they warrant delaying the entirety of the release please make a comment here with:

  • Name or summary of issue
  • Related PR or issue
  • (Optional, if impact isn't denoted by name or summary) Impact on nixos users
  • (Recommended) Timeline of when issue can be resolved or mitigated.

NixOS is a community of volunteers, let's reasonable about time exceptions on getting these issues resolved. As much as I would love to have all scenarios be a tier 1 experience, the reality is that it's just not feasible.

Scenarios involving casual users with "vanilla" (E.g. plasma, gnome, other DEs) desktop needs and production users with security needs (E.g. postgresql) are the two big user bases that I think warrant delaying the release. But the purpose of re-activating this thread is to open a forum for discussing such issues.

@jonringer jonringer pinned this issue Sep 25, 2020
@OPNA2608
Copy link
Contributor

Unsure where to mention this, but would clangMultiStdenv / cc-multilib-test on Hydra being broken since July be a blocker or otherwise noteworthy for the release notes? See #94023, https://hydra.nixos.org/job/nixpkgs/staging-next/tests.cc-multilib-clang.x86_64-linux/

@worldofpeace worldofpeace added the 6.topic: release process Issues or PRs which are parts of the NixOS release process label Oct 5, 2020
@mweinelt
Copy link
Member

mweinelt commented Oct 11, 2020

In #100195 redis default bind is readjusted from wildcard to localhost, which corrects what to me seems like unexpected (no other distro does this) and insecure behaviour (no auth by default) and I'd be glad if we could get that into 20.09.

Not as critical as I expected it to be, because redis defaults to protected mode when not bound to localhost and accessed without password.

@worldofpeace
Copy link
Contributor

worldofpeace commented Oct 11, 2020

I wanted to land this feature, even though I know it's dead last minute #100199

@rissson
Copy link
Member

rissson commented Oct 19, 2020

In my mind #101099 is a blocker. Sorry if that was the wrong issue to post this.

@jonringer
Copy link
Contributor Author

This issue has served it's purpose. With #101736 merged, I think this is good to close

@jonringer jonringer unpinned this issue Oct 28, 2020
@nixos-discourse
Copy link

This issue has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/procedure-for-adding-haskell-hackage-package-to-nixpkgs/10106/4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.kind: enhancement Add something new 6.topic: release process Issues or PRs which are parts of the NixOS release process
Projects
None yet
Development

No branches or pull requests