-
-
Notifications
You must be signed in to change notification settings - Fork 14.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build failure: sonarr #360592
Comments
https://github.com/NixOS/nixpkgs/blob/nixos-24.11/pkgs/by-name/so/sonarr/package.nix
Are the offending values |
yeah, i tried just replacing them with looking in upstream i am under the impression this can build with i didn't investigate further than that |
Upstream hasn't updated to .NET 8, but some attempt was made: Sonarr/Sonarr#6597 (from here you can check the linked PRs) It takes a lot of effort for them to properly update to .NET 8, but for us applying some bare minimum patches (perhaps from Sonarr/Sonarr#6983) could work. |
Stumbling here from the Starrs / Sonarr - so apologies for the slight off topic
correct they'll be done in due time. It's not just the apps themselves, but the build servers and associated dependencies Sonarr has ~2 developers working on the project + upstream metadata prowlarr, radarr, lidarr have ~1 ish readarr, whisparr have ~noneish last heard was keeping bsd support - requiring custom build - and older systems support being dropped with net8.0 were the blockers being worked through |
We should always prefer source builds IMO, but someone could add Also, anyone can still build this package with |
i'll include this snippet here as well, citing discourse:
|
Yeah, we used to package the upstream binaries for Sonarr and friends, in fact, but that's not at all the preferred Nixpkgs approach, so we switched to building from source. |
Allow-list the build inputs for `sonarr` until the package is fixed upstream [1]. [1]: NixOS/nixpkgs#360592
Something that isn't sonarr is causing the same error for me, and I can't quite make out what it is from the stack trace... |
Allow-list the build inputs for `sonarr` until the package is fixed upstream [1]. [1]: NixOS/nixpkgs#360592
NixOS/nixpkgs#360592 Signed-off-by: Roman Volosatovs <[email protected]>
NixOS/nixpkgs#360592 Signed-off-by: Roman Volosatovs <[email protected]>
NixOS/nixpkgs#360592 Signed-off-by: Roman Volosatovs <[email protected]>
NixOS/nixpkgs#360592 Signed-off-by: Roman Volosatovs <[email protected]>
Revert after NixOS/nixpkgs#360592 and NixOS/nixpkgs#326335 are sorted out.
* fix(dips): permit botnet 6 Revert after NixOS/nixpkgs#360592 and NixOS/nixpkgs#326335 are sorted out. * fix(deps): allow asp net core
It looks like Sonarr/Sonarr#7443 was merged now, so we can drop the dotnet v6 dependency once sonarr v5 is released! |
v5 isnt even official beta yet and historically sonarr betas last years....just for key context and to manage expectations |
I am only NixOS beginner, so asking out of curiosity: should it not be possible to use nix language to override the source of sonarr - to point it the latest sha on GitHub? So that the latest version of Sonarr is pulled and built on the fly, while evaluation the configuration 🤔 (ofc one would need to accept that the un-released Sonarr may be unstable) |
I think we should update to the tagged version https://github.com/Sonarr/Sonarr/commits/v5.0.0.12 even if it's considered beta. Beta beats insecure dependency. |
Sonarr v5 is not beta nor released in anyway whatsoever. As confirmed by both release methods: When v5 is beta presumably an announcement will be made. If this is so critical perhaps NixOs Folks should simply fork Sonarr and maintain their own version. NixOS users would receive no support from official channels for their third party custom build. |
Anyone who down votes niklaskorz comment, what do you recommend nixpkgs users use? Even enabling insecure packages this package is broken for me. |
please include details - package and service work fine for me on stable, i would like to know what is broken for you |
I also don't have any issues on unstable (ecd26a4). You just need the insecure packages from this comment: #360592 (comment) |
nixpkgs @ 799ba5b
I am compiling again with doCheck = false but it does take like an hour to build for aarch64 |
Steps To Reproduce
Steps to reproduce the behavior:
sonarr
packageBuild log
requires an old version of dotnet (
6.x
) which has security vulnerabilities against it in nixpkgs so it won't build without permitting those vunerabilitiesAdditional context
can we upgrade to dotnet
8
which is LTS?Notify maintainers
Note for maintainers: Please tag this issue in your PR.
@fadenb @purcell @tie
and maybe @corngood, if my memory serves me correctly?
Add a 👍 reaction to issues you find important.
The text was updated successfully, but these errors were encountered: