Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--keep-failed doesn't preserve build directory on failed multiple-outputs build. #123

Closed
jcumming opened this issue Sep 5, 2012 · 4 comments

Comments

@jcumming
Copy link
Contributor

jcumming commented Sep 5, 2012

For example:

{ stdenv, fetchurl, libogg }:                                                                                                                                  

stdenv.mkDerivation rec {                                                                                                                                      
  name = "flac-1.2.1";                                                                                                                                         

  src = fetchurl {                                                                                                                                             
    url = mirror://sourceforge/flac/flac-1.2.1.tar.gz;                                                                                                         
    sha256 = "1pry5lgzfg57pga1zbazzdd55fkgk3v5qy4axvrbny5lrr5s8dcn";                                                                                           
  };                                                                                                                                                           

  buildInputs = [ libogg ];                                                                                                                                    

  patches =                                                                                                                                                    
    [ # Fix for building on GCC 4.3.                                                                                                                           
      (fetchurl {                                                                                                                                              
        url = "http://sources.gentoo.org/viewcvs.py/*checkout*/gentoo-x86/media-libs/flac/files/flac-1.2.1-gcc-4.3-includes.patch?rev=1.1";                    
        sha256 = "1m6ql5vyjb2jlp5qiqp6w0drq1m6x6y3i1dnl5ywywl3zd36k0mr";                                                                                       
      })                                                                                                                                                       
    ];                                                                                                                                                         

  enableParallelBuilding = true;                                                                                                                               

  outputs = [ "dev" "out" "bin" "doc" ];                                                                                                                       

  meta = {                                                                                                                                                     
    homepage = http://flac.sourceforge.net;                                                                                                                    
    description = "Library and tools for encoding and decoding the FLAC lossless audio file format";                                                           
  };                                                                                                                                                           
} 

If this is called with stdenv instead of stdenvMulti, it will fail to produce a bin output. This causes an assertion of the form:

builder for '/nix/store/iicb3pqgczqp9wwmjmx1xy3p0j5rsd8w-flac-1.2.1.drv' 
 failed to produce output path '/nix/store/bvb9sq100agrcxnimkcjjlc48any85hd-flac-1.2.1-bin'.` 

Unfortunately, --keep-failed doesn't keep the build directory around, making the source of the problem difficult to debug.

@shlevy
Copy link
Member

shlevy commented Sep 5, 2012

This is more of an issue for https://github.com/NixOS/nix. Thanks for reporting though!

@jcumming
Copy link
Contributor Author

jcumming commented Sep 5, 2012

Whoops! Is there an easy way to move it?

@shlevy
Copy link
Member

shlevy commented Sep 5, 2012

Not that I know of, sorry.

@edolstra
Copy link
Member

Fixed, thanks!

edolstra pushed a commit to edolstra/nixpkgs that referenced this issue Oct 1, 2013
replace list by listOf using same style as for attrsOf
mweinelt added a commit to mweinelt/nixpkgs that referenced this issue Dec 8, 2019
Disables support for Javascript and PHP:
- Javascript requires an old version of v8
- PHP requires a larger number of dependencies in addition to php-embed

Changelog [1]:

  New features
    - core: add option weechat.look.nick_color_hash_salt to shuffle nick colors (issue NixOS#635)
    - core: add different icons sizes (16x16 to 512x512) (issue NixOS#1347)
    - core: add file weechat.desktop
    - core: add reverse of string for screen in evaluation of expressions with "revscr:"
    - core: add length of string (number of chars and on screen) in evaluation of expressions with "length:xxx" and "lengthscr:xxx"
    - core: add calculation of expression in evaluation of expressions with "calc:xxx" (issue NixOS#997)
    - core: add optional default path (evaluated) in completion "filename"
    - core: add support of modifiers in evaluation of expressions with "modifier:name,data,string"
    - api: add modifier "color_encode_ansi" (issue NixOS#528)
    - api: add modifier "eval_path_home"
    - irc: add filters on raw buffer (issue NixOS#1000)
    - irc: add option irc.look.display_pv_warning_address to display a warning in private buffer if the remote nick address has changed (issue NixOS#892)
    - irc: add server option "ssl_password" (issue NixOS#115, issue NixOS#1416)
    - irc: add "user" in output of irc_message_parse (issue NixOS#136)
    - irc: add options irc.color.message_kick and irc.color.reason_kick (issue NixOS#683, issue NixOS#684)
    - logger: add option logger.file.color_lines (issue NixOS#528, issue NixOS#621)
    - script: add options "-ol" and "-il" in command "/script list" to send translated string with list of scripts loaded, display "No scripts loaded" if no scripts are loaded
    - xfer: add option xfer.file.download_temporary_suffix with default value ".part" (issue NixOS#1237)

  Bug fixes
    - core: set buffer name, short name and title only if the value has changed
    - core: fix scrolling up in bare mode when switched to bare mode at the top of the buffer (issue NixOS#899, issue NixOS#978)
    - core: optimize load of configuration files
    - core: fix window separators not respecting window splits (issue NixOS#630)
    - core: fix cursor mode info when prefix_align is none and with words split across lines (issue NixOS#610, issue NixOS#617, issue NixOS#619)
    - core: add support of reverse video in ANSI color codes
    - core: fixed segfault during excessive evaluation in function string_repeat (issue NixOS#1400)
    - buflist: fix extra spaces between buffers when conditions are used to hide buffers (regression introduced in version 2.6) (issue NixOS#1403)
    - irc: do not automatically open a channel with name "0" (issue NixOS#1429)
    - irc: remove option irc.network.channel_encode, add server option "charset_message" to control which part of the IRC message is decoded/encoded to the target charset (issue NixOS#832)
    - irc: use path from option xfer.file.upload_path to complete filename in command "/dcc send" (issue NixOS#60)
    - logger: fix write in log file if it has been deleted or renamed (issue NixOS#123)
    - python: send "bytes" instead of "str" to callbacks in Python 3 when the string is not UTF-8 valid (issue NixOS#1389)
    - relay: send message "_buffer_title_changed" to clients only when the title is changed
    - xfer: fix memory leak when a xfer is freed and when the plugin is unloaded

  Tests
    - unit: add tests on GUI color functions

  Build
    - core: fix build on Haiku (issue NixOS#1420)
    - core: fix build on Alpine
    - core: remove file FindTCL.cmake
    - core: display an error on missing dependency in CMake (issue NixOS#916, issue NixOS#956)
    - debian: disable Javascript plugin on Debian Sid and Ubuntu Eoan
    - debian: build with Guile 2.2
    - guile: add support of Guile 2.2, disable /guile eval (issue NixOS#1098)
    - python: add detection of Python 3.8

[1] https://weechat.org/files/changelog/ChangeLog-2.7.html
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this issue Dec 10, 2019
Disables support for Javascript and PHP:
- Javascript requires an old version of v8
- PHP requires a larger number of dependencies in addition to php-embed

Changelog [1]:

  New features
    - core: add option weechat.look.nick_color_hash_salt to shuffle nick colors (issue NixOS#635)
    - core: add different icons sizes (16x16 to 512x512) (issue NixOS#1347)
    - core: add file weechat.desktop
    - core: add reverse of string for screen in evaluation of expressions with "revscr:"
    - core: add length of string (number of chars and on screen) in evaluation of expressions with "length:xxx" and "lengthscr:xxx"
    - core: add calculation of expression in evaluation of expressions with "calc:xxx" (issue NixOS#997)
    - core: add optional default path (evaluated) in completion "filename"
    - core: add support of modifiers in evaluation of expressions with "modifier:name,data,string"
    - api: add modifier "color_encode_ansi" (issue NixOS#528)
    - api: add modifier "eval_path_home"
    - irc: add filters on raw buffer (issue NixOS#1000)
    - irc: add option irc.look.display_pv_warning_address to display a warning in private buffer if the remote nick address has changed (issue NixOS#892)
    - irc: add server option "ssl_password" (issue NixOS#115, issue NixOS#1416)
    - irc: add "user" in output of irc_message_parse (issue NixOS#136)
    - irc: add options irc.color.message_kick and irc.color.reason_kick (issue NixOS#683, issue NixOS#684)
    - logger: add option logger.file.color_lines (issue NixOS#528, issue NixOS#621)
    - script: add options "-ol" and "-il" in command "/script list" to send translated string with list of scripts loaded, display "No scripts loaded" if no scripts are loaded
    - xfer: add option xfer.file.download_temporary_suffix with default value ".part" (issue NixOS#1237)

  Bug fixes
    - core: set buffer name, short name and title only if the value has changed
    - core: fix scrolling up in bare mode when switched to bare mode at the top of the buffer (issue NixOS#899, issue NixOS#978)
    - core: optimize load of configuration files
    - core: fix window separators not respecting window splits (issue NixOS#630)
    - core: fix cursor mode info when prefix_align is none and with words split across lines (issue NixOS#610, issue NixOS#617, issue NixOS#619)
    - core: add support of reverse video in ANSI color codes
    - core: fixed segfault during excessive evaluation in function string_repeat (issue NixOS#1400)
    - buflist: fix extra spaces between buffers when conditions are used to hide buffers (regression introduced in version 2.6) (issue NixOS#1403)
    - irc: do not automatically open a channel with name "0" (issue NixOS#1429)
    - irc: remove option irc.network.channel_encode, add server option "charset_message" to control which part of the IRC message is decoded/encoded to the target charset (issue NixOS#832)
    - irc: use path from option xfer.file.upload_path to complete filename in command "/dcc send" (issue NixOS#60)
    - logger: fix write in log file if it has been deleted or renamed (issue NixOS#123)
    - python: send "bytes" instead of "str" to callbacks in Python 3 when the string is not UTF-8 valid (issue NixOS#1389)
    - relay: send message "_buffer_title_changed" to clients only when the title is changed
    - xfer: fix memory leak when a xfer is freed and when the plugin is unloaded

  Tests
    - unit: add tests on GUI color functions

  Build
    - core: fix build on Haiku (issue NixOS#1420)
    - core: fix build on Alpine
    - core: remove file FindTCL.cmake
    - core: display an error on missing dependency in CMake (issue NixOS#916, issue NixOS#956)
    - debian: disable Javascript plugin on Debian Sid and Ubuntu Eoan
    - debian: build with Guile 2.2
    - guile: add support of Guile 2.2, disable /guile eval (issue NixOS#1098)
    - python: add detection of Python 3.8

[1] https://weechat.org/files/changelog/ChangeLog-2.7.html

(cherry picked from commit d1cb8bf)
mweinelt added a commit to mweinelt/nixpkgs that referenced this issue Feb 20, 2020
Disables support for Javascript and PHP:
- Javascript requires an old version of v8
- PHP requires a larger number of dependencies in addition to php-embed

Changelog [1]:

  New features
    - core: add option weechat.look.nick_color_hash_salt to shuffle nick colors (issue NixOS#635)
    - core: add different icons sizes (16x16 to 512x512) (issue NixOS#1347)
    - core: add file weechat.desktop
    - core: add reverse of string for screen in evaluation of expressions with "revscr:"
    - core: add length of string (number of chars and on screen) in evaluation of expressions with "length:xxx" and "lengthscr:xxx"
    - core: add calculation of expression in evaluation of expressions with "calc:xxx" (issue NixOS#997)
    - core: add optional default path (evaluated) in completion "filename"
    - core: add support of modifiers in evaluation of expressions with "modifier:name,data,string"
    - api: add modifier "color_encode_ansi" (issue NixOS#528)
    - api: add modifier "eval_path_home"
    - irc: add filters on raw buffer (issue NixOS#1000)
    - irc: add option irc.look.display_pv_warning_address to display a warning in private buffer if the remote nick address has changed (issue NixOS#892)
    - irc: add server option "ssl_password" (issue NixOS#115, issue NixOS#1416)
    - irc: add "user" in output of irc_message_parse (issue NixOS#136)
    - irc: add options irc.color.message_kick and irc.color.reason_kick (issue NixOS#683, issue NixOS#684)
    - logger: add option logger.file.color_lines (issue NixOS#528, issue NixOS#621)
    - script: add options "-ol" and "-il" in command "/script list" to send translated string with list of scripts loaded, display "No scripts loaded" if no scripts are loaded
    - xfer: add option xfer.file.download_temporary_suffix with default value ".part" (issue NixOS#1237)

  Bug fixes
    - core: set buffer name, short name and title only if the value has changed
    - core: fix scrolling up in bare mode when switched to bare mode at the top of the buffer (issue NixOS#899, issue NixOS#978)
    - core: optimize load of configuration files
    - core: fix window separators not respecting window splits (issue NixOS#630)
    - core: fix cursor mode info when prefix_align is none and with words split across lines (issue NixOS#610, issue NixOS#617, issue NixOS#619)
    - core: add support of reverse video in ANSI color codes
    - core: fixed segfault during excessive evaluation in function string_repeat (issue NixOS#1400)
    - buflist: fix extra spaces between buffers when conditions are used to hide buffers (regression introduced in version 2.6) (issue NixOS#1403)
    - irc: do not automatically open a channel with name "0" (issue NixOS#1429)
    - irc: remove option irc.network.channel_encode, add server option "charset_message" to control which part of the IRC message is decoded/encoded to the target charset (issue NixOS#832)
    - irc: use path from option xfer.file.upload_path to complete filename in command "/dcc send" (issue NixOS#60)
    - logger: fix write in log file if it has been deleted or renamed (issue NixOS#123)
    - python: send "bytes" instead of "str" to callbacks in Python 3 when the string is not UTF-8 valid (issue NixOS#1389)
    - relay: send message "_buffer_title_changed" to clients only when the title is changed
    - xfer: fix memory leak when a xfer is freed and when the plugin is unloaded

  Tests
    - unit: add tests on GUI color functions

  Build
    - core: fix build on Haiku (issue NixOS#1420)
    - core: fix build on Alpine
    - core: remove file FindTCL.cmake
    - core: display an error on missing dependency in CMake (issue NixOS#916, issue NixOS#956)
    - debian: disable Javascript plugin on Debian Sid and Ubuntu Eoan
    - debian: build with Guile 2.2
    - guile: add support of Guile 2.2, disable /guile eval (issue NixOS#1098)
    - python: add detection of Python 3.8

[1] https://weechat.org/files/changelog/ChangeLog-2.7.html

(cherry picked from commit d1cb8bf)
djfroofy pushed a commit to djfroofy/nixpkgs that referenced this issue Feb 23, 2020
Disables support for Javascript and PHP:
- Javascript requires an old version of v8
- PHP requires a larger number of dependencies in addition to php-embed

Changelog [1]:

  New features
    - core: add option weechat.look.nick_color_hash_salt to shuffle nick colors (issue NixOS#635)
    - core: add different icons sizes (16x16 to 512x512) (issue NixOS#1347)
    - core: add file weechat.desktop
    - core: add reverse of string for screen in evaluation of expressions with "revscr:"
    - core: add length of string (number of chars and on screen) in evaluation of expressions with "length:xxx" and "lengthscr:xxx"
    - core: add calculation of expression in evaluation of expressions with "calc:xxx" (issue NixOS#997)
    - core: add optional default path (evaluated) in completion "filename"
    - core: add support of modifiers in evaluation of expressions with "modifier:name,data,string"
    - api: add modifier "color_encode_ansi" (issue NixOS#528)
    - api: add modifier "eval_path_home"
    - irc: add filters on raw buffer (issue NixOS#1000)
    - irc: add option irc.look.display_pv_warning_address to display a warning in private buffer if the remote nick address has changed (issue NixOS#892)
    - irc: add server option "ssl_password" (issue NixOS#115, issue NixOS#1416)
    - irc: add "user" in output of irc_message_parse (issue NixOS#136)
    - irc: add options irc.color.message_kick and irc.color.reason_kick (issue NixOS#683, issue NixOS#684)
    - logger: add option logger.file.color_lines (issue NixOS#528, issue NixOS#621)
    - script: add options "-ol" and "-il" in command "/script list" to send translated string with list of scripts loaded, display "No scripts loaded" if no scripts are loaded
    - xfer: add option xfer.file.download_temporary_suffix with default value ".part" (issue NixOS#1237)

  Bug fixes
    - core: set buffer name, short name and title only if the value has changed
    - core: fix scrolling up in bare mode when switched to bare mode at the top of the buffer (issue NixOS#899, issue NixOS#978)
    - core: optimize load of configuration files
    - core: fix window separators not respecting window splits (issue NixOS#630)
    - core: fix cursor mode info when prefix_align is none and with words split across lines (issue NixOS#610, issue NixOS#617, issue NixOS#619)
    - core: add support of reverse video in ANSI color codes
    - core: fixed segfault during excessive evaluation in function string_repeat (issue NixOS#1400)
    - buflist: fix extra spaces between buffers when conditions are used to hide buffers (regression introduced in version 2.6) (issue NixOS#1403)
    - irc: do not automatically open a channel with name "0" (issue NixOS#1429)
    - irc: remove option irc.network.channel_encode, add server option "charset_message" to control which part of the IRC message is decoded/encoded to the target charset (issue NixOS#832)
    - irc: use path from option xfer.file.upload_path to complete filename in command "/dcc send" (issue NixOS#60)
    - logger: fix write in log file if it has been deleted or renamed (issue NixOS#123)
    - python: send "bytes" instead of "str" to callbacks in Python 3 when the string is not UTF-8 valid (issue NixOS#1389)
    - relay: send message "_buffer_title_changed" to clients only when the title is changed
    - xfer: fix memory leak when a xfer is freed and when the plugin is unloaded

  Tests
    - unit: add tests on GUI color functions

  Build
    - core: fix build on Haiku (issue NixOS#1420)
    - core: fix build on Alpine
    - core: remove file FindTCL.cmake
    - core: display an error on missing dependency in CMake (issue NixOS#916, issue NixOS#956)
    - debian: disable Javascript plugin on Debian Sid and Ubuntu Eoan
    - debian: build with Guile 2.2
    - guile: add support of Guile 2.2, disable /guile eval (issue NixOS#1098)
    - python: add detection of Python 3.8

[1] https://weechat.org/files/changelog/ChangeLog-2.7.html

(cherry picked from commit d1cb8bf)
Profpatsch pushed a commit that referenced this issue Jun 20, 2020
thinkpad/x1-extreme/gen2: add module
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants