-
-
Notifications
You must be signed in to change notification settings - Fork 14.3k
Commit
- Loading branch information
There are no files selected for viewing
4 comments
on commit d71a485
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This gives:
/nix/store/n3abdjfmnv7rbnxlm2m3f7wjxvrcm0pb-patchelf-0.8/nix-support/setup-hook: line 16: syntax error near unexpected token `<'
/nix/store/n3abdjfmnv7rbnxlm2m3f7wjxvrcm0pb-patchelf-0.8/nix-support/setup-hook: line 16: syntax error near unexpected token `<'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The issue is that the patchelf setup hook is executed by "sh" because it's in the bootstrap.
We could try a different approach: https://github.com/koalaman/shellcheck/wiki/SC2044#for-posix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By the way, I don't know how the fixupOutputHooks works, arrays are not POSIX compatible
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#13395 should fix the issue. Still building locally.
Removing this line breaks the build when
$prefix
does not exit yet. This may happen if the output is created in a postFixup script, like nss does.find
will fail if the searched path does not exist.