Skip to content

Commit

Permalink
Revert "lib: Use lib.fixed-points.extends to avoid repetition"
Browse files Browse the repository at this point in the history
This reverts commit 48ccdf3.
  • Loading branch information
infinisil committed Jul 12, 2018
1 parent b84e951 commit 4794aa5
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion lib/customisation.nix
Original file line number Diff line number Diff line change
Expand Up @@ -202,7 +202,7 @@ rec {
callPackage = self.newScope {};
overrideScope = g:
makeScope newScope
(lib.fixed-points.extends f g);
(self_: let super = f self_; in super // g super self_);
packages = f;
};
in self;
Expand Down

5 comments on commit 4794aa5

@grahamc
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any time you revert a commit, please extend the commit message to say why you reverted it. So, why the revert? :)

@infinisil
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@grahamc Ah right, the discussion is in the reverted commit

@grahamc
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, see: 48ccdf3

@infinisil
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(There's a link to that right under the commits subject as well)

@Ericson2314
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried again in #45394

Please sign in to comment.