Skip to content

Commit

Permalink
kde5.frameworks: use multiple outputs
Browse files Browse the repository at this point in the history
  • Loading branch information
@ttuegel
ttuegel committed Feb 1, 2016
1 parent 6c37beb commit 24d0cfb
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions pkgs/development/libraries/kde-frameworks-5.18/default.nix
View file
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@ let
name = "${name}-${version}";
inherit src;

outputs = [ "dev" "out" ];

This comment has been minimized.

Sign in to view

Copy link
@bennofs

bennofs Apr 30, 2016

Contributor

It looks like nix considers dev to be the default output since it is listed first here. Is this really what we want? I was quite surprised when I found out that ${kde5.breeze-icons} doesn't actually have any icons in it (you need to use ${kde5.breeze-icons.out} to get the icons)

This comment has been minimized.

Sign in to view

Copy link
@ttuegel

ttuegel Apr 30, 2016

Author Member

@bennofs In the particular case of the icons, we should probably override this so there is only the .out output, but in general, this conforms to the convention in Nixpkgs. There is some debate if this is really what we want or not, see #14766. If the default order changes throughout Nixpkgs, of course we would change it here, too.

cmakeFlags =
(args.cmakeFlags or [])
++ [ "-DBUILD_TESTING=OFF" ]
Expand Down

0 comments on commit 24d0cfb

Please sign in to comment.