Update github link to use nixpkgs instead of nixpkgs-channels. #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samueldr
approved these changes
Mar 15, 2021
SuperSandro2000
approved these changes
Mar 15, 2021
garbas
approved these changes
Mar 30, 2021
|
Thank you all for the reviews and for merging! 🙏 |
|
@thequicksort thank you for the work 🥇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, thank you for all your work on this package, I have a minor addendum.
Currently, the generated github link points to the old
nixpkgs-channelrepository (deprecated), while still usingnixpkgscommit hashes:The result is that the github link 404s.
This pull request updates the link to use
nixpkgsproper as the repository. The correct link in this case would be https://github.com/NixOS/nixpkgs/commits/c5147860e23ed75ce9d40298c66b416c00be1167.