Embed the sandbox shell into the statically linked 'nix' binary #6710
+39
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edolstra
force-pushed
the
embedded-sandbox-shell
branch
2 times, most recently
from
b4c41c1 to
5259b31
Compare
With this, Nix will write a copy of the sandbox shell to /bin/sh in the sandbox rather than bind-mounting it from the host filesystem. This makes /bin/sh work out of the box with nix-static, i.e. you no longer get /nix/store/qa36xhc5gpf42l3z1a8m1lysi40l9p7s-bootstrap-stage4-stdenv-linux/setup: ./configure: /bin/sh: bad interpreter: No such file or directory
edolstra
force-pushed
the
embedded-sandbox-shell
branch
from
5259b31 to
925b975
Compare
thufschmitt
reviewed
Jun 23, 2022
| $(d)/build/local-derivation-goal.cc: $(d)/embedded-sandbox-shell.gen.hh | ||
|
|
||
| $(d)/embedded-sandbox-shell.gen.hh: $(sandbox_shell) | ||
| $(trace-gen) hexdump -v -e '1/1 "0x%x," "\n"' < $< > [email protected] |
There was a problem hiding this comment.
I'm not sure it's available in stdenv, but if it is, xxd has a --include option to directly produce a C-compatible header
There was a problem hiding this comment.
Unfortunately, xxd is part of vim which is a pretty big dependency to pull in...
There was a problem hiding this comment.
Uh indeed, didn't know that 😲
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/tweag-nix-dev-update-33/20048/1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this, Nix will write a copy of the sandbox shell to
/bin/shin the sandbox rather than bind-mounting it from the host filesystem. This makes /bin/sh work out of the box with nix-static, i.e. you no longer getThis increases the size of the
nixbinary by 213 KiB.