Copy drv outputs between stores #4220
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For each “known” derivation output, store: - its output id - its output path - its dependencies (this bit isn't implemented for `LocalFSStore` yet and we recompute them on-the-fly instead) This comes with a set of needed changes: - New `drv-output-info` module declaring the types needed for describing these dependencies - New `Store::registerDrvOutput` method registering all the needed informations about a derivation output (also replaces `LocalStore::linkDeriverToPath`) - new `Store::queryDrvOutputInfo` method to retrieve the informations for a derivations This introcudes some redundancy on the remote-store side between `wopQueryDerivationOutputMap` and `wopQueryDrvOutputInfo`. However we might need to keep both (regardless of backwards compat) because we sometimes need to get some infos for all the outputs of a derivation (where `wopQueryDerivationOutputMap` is handy), but all the stores can't implement it − because listing all the outputs of a derivation isn't really possible for binary caches where the server doesn't allow to list a directory.
Copying a derivation output is equivalent to copy the output path, except that it will also link the output to the path (with `linkDeriverToPath` on the remote store)
Commands that accept store paths or installables as input can now take a derivation path with outputs. Like when the input is a nix expr, the derivation will be realised if needed.
Generalises `StorePathsCommand` to allow manipulating `Buildables` rather than just store paths.
…d path Fix NixOS#4138 and allows copying drv outputs without having to copy the whole drv closure
That way we can `nix copy --from` a store that doesn't have the derivation but just its outputs
This isn't really satisfying. It'll probably be nicer to have two separate sql tables for the path references and the drvoutput references in the end
|
Closing in favor of #4225 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial (cleaner) rewrite of #4174. This PR doesn't try to get substitution to work, just to be able to manually copy drv outputs closures between stores (which is already a big deal).
The exact schema of the local db and the remote caches isn't really set yet, but we're hopefully approaching it. The rational behind most of the changes is (lengthily) explained in https://hackmd.io/@Xs46ZZwNQtOhEkXnSehjeA/rkDU1BTOv