-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fetchTree unpacks tarballs incorrectly #11656
Labels
Comments
Considering #10575 maybe the git tree object for a directory gets replaced when a tarball contains multiple files in different directories in mixed order. Would match to the observation, that only the files in the last mention of |
|
edolstra
added a commit
to DeterminateSystems/nix-src
that referenced
this issue
Oct 14, 2024
I.e. when not all entries underneath a directory X follow eachother, but there is some entry Y that isn't a child of X in between. Fixes NixOS#11656.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
fetchTree {type="tarball"; url="https://csspeechstorage.blob.core.windows.net/drop/1.40.0/SpeechSDK-Linux-1.40.0.tar.gz";}
doesn't correctly unpack the fetched tarball.
The tarball in question contains files not ordered by paths so files in different subpaths are mixed. It looks like only the last bunch of files for a subdirectory is kept.
Steps To Reproduce
Expected behavior
The tarball should be correctly unpacked, so that all files contained in the tarball are present in
/nix/store/7y7k5xz1ryzzn41vvc5amz2fvziz4zjj-source
or whatever its store path will then be.nix-env --version
outputAdditional context
I deleted
~/.cache/nix
multiple times, while trying around with this. So the tarball cache was also refreshed multiple times. Alsonix-collect-garbage -d
got rid of the store path/nix/store/7y7k5xz1ryzzn41vvc5amz2fvziz4zjj-source
multiple times for me, so hopefully it wasn't just a faulty download sticking to some cache ...
Priorities
This makes flake inputs of type
tarball
dangerous for now. So I guess it is pretty severe.Add 👍 to issues you find important.
The text was updated successfully, but these errors were encountered: