Add manual triage view #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alejandrosame
force-pushed
the
feat/triage-view
branch
from
6db8c21 to
8a4375b
Compare
|
Some notes:
|
Comment on lines
+275
to
+299
| def _get_cve_page( | ||
| self, search_cves: str | None, cve_page_number: int | ||
| ) -> tuple[Page, CustomCountPaginator]: | ||
| cve_qs, cve_count_function = self._get_cve_qs(search_cves) | ||
| cve_paginator = CustomCountPaginator( | ||
| cve_qs, self.paginate_by, custom_count=cve_count_function | ||
| ) | ||
| cve_page = cve_paginator.get_page(cve_page_number) | ||
| return cve_page, cve_paginator | ||
|
|
||
| def _get_pkg_page( | ||
| self, search_pkgs: str | None, pkg_page_number: int | ||
| ) -> tuple[Page, CustomCountPaginator]: | ||
| pkg_qs, pkg_count_function = self._get_pkg_qs(search_pkgs) | ||
| pkg_paginator = CustomCountPaginator( | ||
| pkg_qs, self.paginate_by, custom_count=pkg_count_function | ||
| ) | ||
| pkg_page = pkg_paginator.get_page(pkg_page_number) | ||
| return pkg_page, pkg_paginator |
There was a problem hiding this comment.
Not critical: One could pass what's currently _get_cve_qs and _get_pkgs_qs as a parameter _get_queryset, and rename the search string and page number variables to be more generic. But it's okay for now, the duplication is not super confusing.
fricklerhandwerk
approved these changes
Aug 14, 2024
Comment on lines
+229
to
+234
| <span class="cve-header-actions"> | ||
| <input type="checkbox" class="cve-checkbox" | ||
| data-id="{{object.cve_id}}" value="{{object.cve_id}}" | ||
| name="cve" form="issue-form" | ||
| > | ||
| </span> |
There was a problem hiding this comment.
Suggested change
| <span class="cve-header-actions"> | |
| <input type="checkbox" class="cve-checkbox" | |
| data-id="{{object.cve_id}}" value="{{object.cve_id}}" | |
| name="cve" form="issue-form" | |
| > | |
| </span> | |
| <input type="checkbox" class="cve-checkbox" | |
| data-id="{{object.cve_id}}" value="{{object.cve_id}}" | |
| name="cve" form="issue-form" | |
| > |
Not a blocker: I don't think the additional wrapper is necessary, you can already select .cve-checkbox.
Comment on lines
+235
to
+241
| <span class="cve-header-description"> | ||
| <span class="cve-db-id">{{ object.id }}</span> | ||
| <span class="cve-id">{{ object.cve_id_code }}</span> | ||
| <div class="cve-header-description-long"> | ||
| {{ object.title | default_to_na }} | ||
| </div> | ||
| </span> |
There was a problem hiding this comment.
Suggested change
| <span class="cve-header-description"> | |
| <span class="cve-db-id">{{ object.id }}</span> | |
| <span class="cve-id">{{ object.cve_id_code }}</span> | |
| <div class="cve-header-description-long"> | |
| {{ object.title | default_to_na }} | |
| </div> | |
| </span> | |
| <span class="cve-db-id">{{ object.id }}</span> | |
| <span class="cve-id">{{ object.cve_id_code }}</span> | |
| <div class="cve-header-description-long"> | |
| {{ object.title | default_to_na }} | |
| </div> |
Not a blocker: Possibly not necessary either, because you should be able to control rendering through the container, but not sure from just reading the text.
| </span> | ||
| </summary> | ||
| <div class="cve-extra-info"> | ||
| <hr> |
There was a problem hiding this comment.
Suggested change
| <hr> |
Not a blocker: You can invoke that in CSS
|
Please rewrite history and I'll merge. |
Doing it after this last commit. Now there's some basic checkbox state management, but I'm skipping the CSS/HTML change suggestions |
alejandrosame
force-pushed
the
feat/triage-view
branch
from
d71dbe0 to
685352d
Compare
fricklerhandwerk
force-pushed
the
feat/triage-view
branch
from
685352d to
9ce583b
Compare
This enables to search through available CVE containers in the database using a very simple PostgreSQL TS vector search.
According to the specs of the VM.
This view allows users to filter CVEs and packages, link them and create
NixpkgsIssue from their selections.
Model changes:
- Added **SearchVectorField** to improve performance of full-text search.
- Indices added for performance improvements:
- **GinIndex** for SearchVectorFields.
- **BTreeIndex** for fields to be searched for filtering and aggregation.
fricklerhandwerk
force-pushed
the
feat/triage-view
branch
from
9ce583b to
eb79cd4
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This view allows users to filter CVEs and packages, link them and create NixpkgsIssue from their selections.
Model changes:
Part of #5