Check secrets app PIN before setting the new reverse hotp credential #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daringer
approved these changes
Apr 24, 2024
If the PIN is not set, configure it. Nitrokeys prior to Nitrokey/trussed-secrets-app#114 will ignore the PIN. It might surprise users that have not set a PIN in the past that a PIN is now set. Nitrokeys with firmware after Nitrokey/trussed-secrets-app#114 will accept expect this behaviour from hotp-verification
sosthene-nitrokey
force-pushed
the
check-pin-or-set-it
branch
from
2e742c0
to
8e63fa4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the PIN is not set, configure it.
Nitrokeys prior to Nitrokey/trussed-secrets-app#114 will ignore the PIN. It might surprise users that have not set a PIN in the past that a PIN is now set.
Nitrokeys with firmware after Nitrokey/trussed-secrets-app#114 will accept expect this behaviour from hotp-verification