Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

corrected bookmark-toggle effect #68

Merged
merged 1 commit into from
May 14, 2024
Merged

corrected bookmark-toggle effect #68

merged 1 commit into from
May 14, 2024

Conversation

venkatasai24
Copy link

Fixes Issue

Fixed the bookmark-toggle button in the posts

Changes proposed

Updated toggle effect using isSaved variable which is good enough...

Screenshots

Screencast.from.2024-05-14.19-14-56.webm

Note

There are issues within the backend of adding saved posts into the respective user account, I don't know much about the typescript :(, but I would try to learn and resolve that issue ( If it is assigned to a level-3 label :) )
Until then, I hope you will love the current changes I made @Nishitbaria (Don't forget to add a level-1 label !!)

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, venkatasai24, for creating this pull request and contributing to OpenGrame! 💗

The maintainers will review this Pull Request and provide feedback as soon as possible! 😇
We appreciate your patience and contribution, Keep up the great work! 😀

@Nishitbaria Nishitbaria added good first issue Good for newcomers gssoc Girl Script Summer of Code level2 Modifying an existing feature labels May 14, 2024
@Nishitbaria
Copy link
Owner

Thank you for your contribution @venkatasai24

@Nishitbaria Nishitbaria merged commit c2d20aa into Nishitbaria:main May 14, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers gssoc Girl Script Summer of Code level2 Modifying an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants