Check errors in docker_discovery.go #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mihaitodor
force-pushed
the
mihaitodor/check-errors-docker-discovery
branch
from
76fa941 to
97c6474
Compare
relistan
requested changes
Nov 7, 2018
mihaitodor
force-pushed
the
mihaitodor/check-errors-docker-discovery
branch
from
97c6474 to
cc22ed3
Compare
relistan
reviewed
Nov 19, 2018
|
One minor thing, then |
mihaitodor
force-pushed
the
mihaitodor/check-errors-docker-discovery
branch
from
cc22ed3 to
804f4d8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like we're missing some error checks in there and we should keep on retrying to connect even if
d.ClientProvider()fails the first time.Also, the
forloop inmanageConnectionwas callingdocker.NewClient(d.endpoint)instead ofd.ClientProvider(), which seems wrong to me, becaused.ClientProvider()resolves tod.getDockerClient(), which is able to calldocker.NewClientFromEnv(), in cased.endpoint == "".I also fixed a flaky test in
static_discovery.TODO:
panic: send on closed channelatvendor/github.com/fsouza/go-dockerclient/event.go:344