-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use nix #614
Use nix #614
Conversation
c0a8c53
to
a0d813c
Compare
5288fba
to
e919736
Compare
bin/transpiler/CMakeLists.txt
Outdated
${CMAKE_SOURCE_DIR}/libs/assigner/include | ||
${CMAKE_SOURCE_DIR}/libs/transpiler/include |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The same
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
libs/transpiler/include
still remains
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tried removing it, it seems, it does not export the targets the right way.
bin/assigner/CMakeLists.txt
Outdated
${CMAKE_CURRENT_SOURCE_DIR}/../../libs/circifier/utils/bazel/llvm-project-overlay/llvm/include | ||
${CMAKE_SOURCE_DIR}/libs/circifier/llvm/include | ||
${CMAKE_SOURCE_DIR}/libs/circifier/utils/bazel/llvm-project-overlay/llvm/include | ||
${CMAKE_SOURCE_DIR}/libs/assigner/include |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The same
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
libs/assigner/include
still remains
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tried removing it, it seems, it does not export the targets the right way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it is not enough just to remove it. But you can restore crypto3::assigner
and crypto3::transpiler
as it was at lines 55-56 of the previous version of the file. It is basically the same way as you have just fixed bin/recursive_gen/CMakeLists.txt
, so I am almost sure that it would work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's try use interface libraries: crypto3::assigner and crypto3::transpiler.
Sound like quick change. If doesn't works - keep as is
4d8469b
to
a0cc252
Compare
07c8201
to
1bd3267
Compare
No description provided.