Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

95 rw in bbf #115

Merged
merged 1 commit into from
Dec 5, 2024
Merged

95 rw in bbf #115

merged 1 commit into from
Dec 5, 2024

Conversation

ETatuzova
Copy link
Contributor

No description provided.

@ETatuzova ETatuzova self-assigned this Oct 29, 2024
@ETatuzova ETatuzova linked an issue Oct 29, 2024 that may be closed by this pull request
RW in BBF #95
Closed
@ETatuzova ETatuzova force-pushed the 95-rw-in-bbf branch 10 times, most recently from b4fade2 to ad5db16 Compare December 4, 2024 19:34
@ETatuzova ETatuzova closed this Dec 5, 2024
@ETatuzova ETatuzova reopened this Dec 5, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 5, 2024 •
edited
Loading

Clang Test Results

  159 files   - 2    159 suites   - 2   22m 26s ⏱️ +50s
3 485 tests  - 5  3 479 ✅  - 5  6 💤 ±0  0 ❌ ±0 
3 547 runs   - 5  3 541 ✅  - 5  6 💤 ±0  0 ❌ ±0 

Results for commit 770fce7. ± Comparison against base commit 45118d5.

This pull request removes 24 and adds 19 tests. Note that renamed tests count towards both. 
blueprint_bbf_copy ‑ calldatacopy_contract
blueprint_bbf_copy ‑ keccak_contract
blueprint_bbf_copy ‑ meminit_contract
blueprint_bbf_copy ‑ mstore8_contract
blueprint_bbf_copy ‑ small_storage_contract
blueprint_bbf_rw ‑ calldatacopy_contract
blueprint_bbf_rw ‑ meminit_contract
blueprint_bbf_rw ‑ minimal_math_contract
blueprint_bbf_rw ‑ mstore8_contract
blueprint_bbf_rw ‑ small_storage_contract
…

blueprint_bbf_rw ‑ calldatacopy
blueprint_bbf_rw ‑ meminit
blueprint_bbf_rw ‑ minimal_math
blueprint_bbf_rw ‑ mstore8
blueprint_bbf_rw ‑ small_storage
zkevm_bbf_copy ‑ calldatacopy_contract
zkevm_bbf_copy ‑ keccak_contract
zkevm_bbf_copy ‑ meminit_contract
zkevm_bbf_copy ‑ mstore8_contract
zkevm_bbf_copy ‑ small_storage_contract
…

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 5, 2024 •
edited
Loading

Gcc Test Results

  160 files   -  2    160 suites   - 2   47m 2s ⏱️ +54s
3 395 tests  - 98  3 389 ✅  - 98  6 💤 ±0  0 ❌ ±0 
3 457 runs   - 98  3 451 ✅  - 98  6 💤 ±0  0 ❌ ±0 

Results for commit 770fce7. ± Comparison against base commit 45118d5.

This pull request removes 123 and adds 25 tests. Note that renamed tests count towards both. 
blueprint_bbf_copy ‑ calldatacopy_contract
blueprint_bbf_copy ‑ keccak_contract
blueprint_bbf_copy ‑ meminit_contract
blueprint_bbf_copy ‑ mstore8_contract
blueprint_bbf_copy ‑ small_storage_contract
blueprint_bbf_rw ‑ calldatacopy_contract
blueprint_bbf_rw ‑ meminit_contract
blueprint_bbf_rw ‑ minimal_math_contract
blueprint_bbf_rw ‑ mstore8_contract
blueprint_bbf_rw ‑ small_storage_contract
…

blueprint_bbf_rw ‑ calldatacopy
blueprint_bbf_rw ‑ meminit
blueprint_bbf_rw ‑ minimal_math
blueprint_bbf_rw ‑ mstore8
blueprint_bbf_rw ‑ small_storage
pack_imploder_test_suite ‑ be_to_be_1
pack_imploder_test_suite ‑ be_to_be_2
pack_imploder_test_suite ‑ be_to_le_1
pack_imploder_test_suite ‑ be_to_le_2
pack_imploder_test_suite ‑ be_to_le_3
…

♻️ This comment has been updated with latest results.

@ETatuzova ETatuzova marked this pull request as ready for review December 5, 2024 09:11
@ETatuzova ETatuzova requested a review from akokoshn December 5, 2024 09:11
@ETatuzova ETatuzova force-pushed the 95-rw-in-bbf branch 3 times, most recently from e2caab7 to 5c0f81f Compare December 5, 2024 09:28
akokoshn
akokoshn approved these changes Dec 5, 2024
View reviewed changes
crypto3/libs/blueprint/include/nil/blueprint/bbf/generic.hpp Outdated Show resolved Hide resolved
crypto3/libs/blueprint/include/nil/blueprint/zkevm_bbf/copy.hpp Outdated Show resolved Hide resolved
crypto3/libs/blueprint/include/nil/blueprint/zkevm_bbf/opcodes/add_sub.hpp Outdated Show resolved Hide resolved
crypto3/libs/blueprint/include/nil/blueprint/zkevm_bbf/opcodes/div_mod.hpp Outdated Show resolved Hide resolved
crypto3/libs/blueprint/include/nil/blueprint/zkevm_bbf/opcodes/iszero.hpp Outdated Show resolved Hide resolved
crypto3/libs/blueprint/include/nil/blueprint/zkevm_bbf/rw.hpp Outdated Show resolved Hide resolved
crypto3/libs/blueprint/include/nil/blueprint/zkevm_bbf/rw.hpp Outdated Show resolved Hide resolved
crypto3/libs/blueprint/include/nil/blueprint/zkevm_bbf/subcomponents/exp_table.hpp Show resolved Hide resolved
crypto3/libs/blueprint/include/nil/blueprint/zkevm_bbf/types/rw_operation.hpp Show resolved Hide resolved
@ETatuzova ETatuzova force-pushed the 95-rw-in-bbf branch 2 times, most recently from cff81e6 to 58384b3 Compare December 5, 2024 13:17
@ETatuzova ETatuzova requested review from akokoshn and oclaw December 5, 2024 16:59
@ETatuzova ETatuzova enabled auto-merge December 5, 2024 18:35
@ETatuzova ETatuzova added this pull request to the merge queue Dec 5, 2024
Merged via the queue into master with commit 850312c Dec 5, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oclaw oclaw oclaw approved these changes

@akokoshn akokoshn Awaiting requested review from akokoshn

Assignees

@ETatuzova ETatuzova

Labels
blueprint
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RW in BBF
3 participants
@ETatuzova @akokoshn @oclaw