-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GooglePreprocessor and SmartPreprocessor #84
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please go back to two-space for this PR so I can properly review the actual changes. We can think about converting the code base to four-space in another PR.
Please also be aware that I'm working on a new version that parses the code with Anyway, happy to merge your PR into the 2.x code base. I'll likely copy the processor code to the 3.x branch afterwards. |
Rebased to master, should be no conflicts now. |
This reverts commit e3527b2.
Please take a look at the |
I will take a look, thanks! Actually, I implemented GooglePrerocessor incorrectly, it also supports https://www.python.org/dev/peps/pep-0257 we should probably split these two guys, and we can create a parent class for them as methods will be the same, just param regexps should be different. FOr now logic for detecting docstring style is quite simple. If I find a section from Google/PEP-0257 - |
Fixed, regexp was incorrect. |
GooglePreprocessor - supports Google format for docstrings
SmartPreprocessor - wisely chooses between RST and Google preprocessors for each docstring